Commit 383efcd0 authored by Tejun Heo's avatar Tejun Heo Committed by Ingo Molnar

sched: Convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s

try_to_wake_up_local() should only be invoked to wake up another
task in the same runqueue and BUG_ON()s are used to enforce the
rule. Missing try_to_wake_up_local() can stall workqueue
execution but such stalls are likely to be finite either by
another work item being queued or the one blocked getting
unblocked.  There's no reason to trigger BUG while holding rq
lock crashing the whole system.

Convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s.
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Acked-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20130318192234.GD3042@htj.dyndns.orgSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 7f6575f1
...@@ -1488,8 +1488,10 @@ static void try_to_wake_up_local(struct task_struct *p) ...@@ -1488,8 +1488,10 @@ static void try_to_wake_up_local(struct task_struct *p)
{ {
struct rq *rq = task_rq(p); struct rq *rq = task_rq(p);
BUG_ON(rq != this_rq()); if (WARN_ON_ONCE(rq != this_rq()) ||
BUG_ON(p == current); WARN_ON_ONCE(p == current))
return;
lockdep_assert_held(&rq->lock); lockdep_assert_held(&rq->lock);
if (!raw_spin_trylock(&p->pi_lock)) { if (!raw_spin_trylock(&p->pi_lock)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment