Commit 3894817f authored by Himangi Saraogi's avatar Himangi Saraogi Committed by Scott Wood

powerpc/fsl-pci: Correct use of ! and &

In commit ae91d60b, a bug was fixed that
involved converting !x & y to !(x & y).  The code below shows the same
pattern, and thus should perhaps be fixed in the same way.

This is not tested and clearly changes the semantics, so it is only
something to consider.

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@@ expression E1,E2; @@
(
  !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// </smpl>
Signed-off-by: default avatarHimangi Saraogi <himangi774@gmail.com>
Signed-off-by: default avatarScott Wood <scottwood@freescale.com>
parent 983e2444
...@@ -853,8 +853,8 @@ u64 fsl_pci_immrbar_base(struct pci_controller *hose) ...@@ -853,8 +853,8 @@ u64 fsl_pci_immrbar_base(struct pci_controller *hose)
in = pcie->cfg_type0 + PEX_RC_INWIN_BASE; in = pcie->cfg_type0 + PEX_RC_INWIN_BASE;
for (i = 0; i < 4; i++) { for (i = 0; i < 4; i++) {
/* not enabled, skip */ /* not enabled, skip */
if (!in_le32(&in[i].ar) & PEX_RCIWARn_EN) if (!(in_le32(&in[i].ar) & PEX_RCIWARn_EN))
continue; continue;
if (get_immrbase() == in_le32(&in[i].tar)) if (get_immrbase() == in_le32(&in[i].tar))
return (u64)in_le32(&in[i].barh) << 32 | return (u64)in_le32(&in[i].barh) << 32 |
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment