Commit 39dbf66e authored by Feng Wu's avatar Feng Wu Committed by Kamal Mostafa

KVM: Disable SMAP for guests in EPT realmode and EPT unpaging mode

commit e1e746b3 upstream.

SMAP is disabled if CPU is in non-paging mode in hardware.
However KVM always uses paging mode to emulate guest non-paging
mode with TDP. To emulate this behavior, SMAP needs to be
manually disabled when guest switches to non-paging mode.
Signed-off-by: default avatarFeng Wu <feng.wu@intel.com>
Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
[ kamal: 3.13-stable prereq for
  656ec4a4 KVM: VMX: fix SMEP and SMAP without EPT ]
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent 9514f3ce
...@@ -3429,13 +3429,14 @@ static int vmx_set_cr4(struct kvm_vcpu *vcpu, unsigned long cr4) ...@@ -3429,13 +3429,14 @@ static int vmx_set_cr4(struct kvm_vcpu *vcpu, unsigned long cr4)
hw_cr4 &= ~X86_CR4_PAE; hw_cr4 &= ~X86_CR4_PAE;
hw_cr4 |= X86_CR4_PSE; hw_cr4 |= X86_CR4_PSE;
/* /*
* SMEP is disabled if CPU is in non-paging mode in * SMEP/SMAP is disabled if CPU is in non-paging mode
* hardware. However KVM always uses paging mode to * in hardware. However KVM always uses paging mode to
* emulate guest non-paging mode with TDP. * emulate guest non-paging mode with TDP.
* To emulate this behavior, SMEP needs to be manually * To emulate this behavior, SMEP/SMAP needs to be
* disabled when guest switches to non-paging mode. * manually disabled when guest switches to non-paging
* mode.
*/ */
hw_cr4 &= ~X86_CR4_SMEP; hw_cr4 &= ~(X86_CR4_SMEP | X86_CR4_SMAP);
} else if (!(cr4 & X86_CR4_PAE)) { } else if (!(cr4 & X86_CR4_PAE)) {
hw_cr4 &= ~X86_CR4_PAE; hw_cr4 &= ~X86_CR4_PAE;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment