Commit 3a0af333 authored by Paul E. McKenney's avatar Paul E. McKenney

rcutorture: Fix rcu_torture_cbflood() for callback-free RCU

The rcu_torture_cbflood() function correctly checks for flavors of
RCU that lack analogs to call_rcu() and rcu_barrier(), but in that
case it fails to terminate correctly.  In fact, it terminates so
incorrectly that segfaults can result.  This commit therefore causes
rcu_torture_cbflood() to do the proper wait-for-stop procedure.
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent e8e255f7
...@@ -823,9 +823,7 @@ rcu_torture_cbflood(void *arg) ...@@ -823,9 +823,7 @@ rcu_torture_cbflood(void *arg)
} }
if (err) { if (err) {
VERBOSE_TOROUT_STRING("rcu_torture_cbflood disabled: Bad args or OOM"); VERBOSE_TOROUT_STRING("rcu_torture_cbflood disabled: Bad args or OOM");
while (!torture_must_stop()) goto wait_for_stop;
schedule_timeout_interruptible(HZ);
return 0;
} }
VERBOSE_TOROUT_STRING("rcu_torture_cbflood task started"); VERBOSE_TOROUT_STRING("rcu_torture_cbflood task started");
do { do {
...@@ -844,6 +842,7 @@ rcu_torture_cbflood(void *arg) ...@@ -844,6 +842,7 @@ rcu_torture_cbflood(void *arg)
stutter_wait("rcu_torture_cbflood"); stutter_wait("rcu_torture_cbflood");
} while (!torture_must_stop()); } while (!torture_must_stop());
vfree(rhp); vfree(rhp);
wait_for_stop:
torture_kthread_stopping("rcu_torture_cbflood"); torture_kthread_stopping("rcu_torture_cbflood");
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment