Commit 3a5a5673 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

USB: serial: garmin_gps: fix memory leak on probe errors

commit 74d471b5 upstream.

Make sure to free the port private data before returning after a failed
probe attempt.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent df2ca939
...@@ -1413,6 +1413,12 @@ static int garmin_port_probe(struct usb_serial_port *port) ...@@ -1413,6 +1413,12 @@ static int garmin_port_probe(struct usb_serial_port *port)
usb_set_serial_port_data(port, garmin_data_p); usb_set_serial_port_data(port, garmin_data_p);
status = garmin_init_session(port); status = garmin_init_session(port);
if (status)
goto err_free;
return 0;
err_free:
kfree(garmin_data_p);
return status; return status;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment