Commit 3a6e005e authored by Felipe Balbi's avatar Felipe Balbi Committed by Jiri Slaby

usb: dwc3: core: fix ordering for PHY suspend

commit dc99f16f upstream.

We can't suspend the PHYs before dwc3_core_exit_mode()
has been called, that's because the host and/or device
sides might still need to communicate with the far end
link partner.

Fixes: 8ba007a9 (usb: dwc3: core: enable the USB2 and USB3 phy in probe)
Suggested-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent ae0262d6
...@@ -581,9 +581,6 @@ static int dwc3_remove(struct platform_device *pdev) ...@@ -581,9 +581,6 @@ static int dwc3_remove(struct platform_device *pdev)
{ {
struct dwc3 *dwc = platform_get_drvdata(pdev); struct dwc3 *dwc = platform_get_drvdata(pdev);
usb_phy_set_suspend(dwc->usb2_phy, 1);
usb_phy_set_suspend(dwc->usb3_phy, 1);
dwc3_debugfs_exit(dwc); dwc3_debugfs_exit(dwc);
switch (dwc->dr_mode) { switch (dwc->dr_mode) {
...@@ -604,6 +601,10 @@ static int dwc3_remove(struct platform_device *pdev) ...@@ -604,6 +601,10 @@ static int dwc3_remove(struct platform_device *pdev)
dwc3_event_buffers_cleanup(dwc); dwc3_event_buffers_cleanup(dwc);
dwc3_free_event_buffers(dwc); dwc3_free_event_buffers(dwc);
usb_phy_set_suspend(dwc->usb2_phy, 1);
usb_phy_set_suspend(dwc->usb3_phy, 1);
dwc3_core_exit(dwc); dwc3_core_exit(dwc);
pm_runtime_put_sync(&pdev->dev); pm_runtime_put_sync(&pdev->dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment