Commit 3abedf46 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Shuah Khan

selftests: harness: avoid false negatives if test has no ASSERTs

Test can fail either immediately when ASSERT() failed or at the
end if one or more EXPECT() was not met. The exact return code
is decided based on the number of successful ASSERT()s.

If test has no ASSERT()s, however, the return code will be 0,
as if the test did not fail. Start counting ASSERT()s from 1.

Fixes: 369130b6 ("selftests: Enhance kselftest_harness.h to print which assert failed")
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent e5992f37
...@@ -969,7 +969,7 @@ void __run_test(struct __fixture_metadata *f, ...@@ -969,7 +969,7 @@ void __run_test(struct __fixture_metadata *f,
t->passed = 1; t->passed = 1;
t->skip = 0; t->skip = 0;
t->trigger = 0; t->trigger = 0;
t->step = 0; t->step = 1;
t->no_print = 0; t->no_print = 0;
memset(t->results->reason, 0, sizeof(t->results->reason)); memset(t->results->reason, 0, sizeof(t->results->reason));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment