Commit 3ada0b33 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller

netlink: specs: ovs: remove fixed header fields from attrs

Op's "attributes" list is a workaround for families with a single
attr set. We don't want to render a single huge request structure,
the same for each op since we know that most ops accept only a small
set of attributes. "Attributes" list lets us narrow down the attributes
to what op acctually pays attention to.

It doesn't make sense to put names of fixed headers in there.
They are not "attributes" and we can't really narrow down the struct
members.

Remove the fixed header fields from attrs for ovs families
in preparation for C codegen support.
Reviewed-by: default avatarDonald Hunter <donald.hunter@gmail.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 283f105b
...@@ -142,7 +142,6 @@ operations: ...@@ -142,7 +142,6 @@ operations:
do: do:
request: request:
attributes: attributes:
- dp-ifindex
- name - name
- upcall-pid - upcall-pid
- user-features - user-features
...@@ -154,7 +153,6 @@ operations: ...@@ -154,7 +153,6 @@ operations:
do: do:
request: request:
attributes: attributes:
- dp-ifindex
- name - name
mcast-groups: mcast-groups:
......
...@@ -947,13 +947,11 @@ operations: ...@@ -947,13 +947,11 @@ operations:
do: &flow-get-op do: &flow-get-op
request: request:
attributes: attributes:
- dp-ifindex
- key - key
- ufid - ufid
- ufid-flags - ufid-flags
reply: reply:
attributes: attributes:
- dp-ifindex
- key - key
- ufid - ufid
- mask - mask
...@@ -968,7 +966,6 @@ operations: ...@@ -968,7 +966,6 @@ operations:
do: do:
request: request:
attributes: attributes:
- dp-ifindex
- key - key
- ufid - ufid
- mask - mask
......
...@@ -135,7 +135,6 @@ operations: ...@@ -135,7 +135,6 @@ operations:
- name - name
- type - type
- upcall-pid - upcall-pid
- dp-ifindex
- ifindex - ifindex
- options - options
- -
...@@ -146,7 +145,6 @@ operations: ...@@ -146,7 +145,6 @@ operations:
do: do:
request: request:
attributes: attributes:
- dp-ifindex
- port-no - port-no
- type - type
- name - name
...@@ -158,11 +156,9 @@ operations: ...@@ -158,11 +156,9 @@ operations:
do: &vport-get-op do: &vport-get-op
request: request:
attributes: attributes:
- dp-ifindex
- name - name
reply: &dev-all reply: &dev-all
attributes: attributes:
- dp-ifindex
- port-no - port-no
- type - type
- name - name
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment