Commit 3b3299a1 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Kalle Valo

wil6210: use NAPI_POLL_WEIGHT for napi budget

The comment next to WIL6210_NAPI_BUDGET says "arbitrary".
If we're picking arbitrary values let's pick the recommended
default which is NAPI_POLL_WEIGHT.
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20220429174643.196994-4-kuba@kernel.org
parent 52bcfd1b
...@@ -457,17 +457,17 @@ int wil_if_add(struct wil6210_priv *wil) ...@@ -457,17 +457,17 @@ int wil_if_add(struct wil6210_priv *wil)
if (wil->use_enhanced_dma_hw) { if (wil->use_enhanced_dma_hw) {
netif_napi_add(&wil->napi_ndev, &wil->napi_rx, netif_napi_add(&wil->napi_ndev, &wil->napi_rx,
wil6210_netdev_poll_rx_edma, wil6210_netdev_poll_rx_edma,
WIL6210_NAPI_BUDGET); NAPI_POLL_WEIGHT);
netif_tx_napi_add(&wil->napi_ndev, netif_tx_napi_add(&wil->napi_ndev,
&wil->napi_tx, wil6210_netdev_poll_tx_edma, &wil->napi_tx, wil6210_netdev_poll_tx_edma,
WIL6210_NAPI_BUDGET); NAPI_POLL_WEIGHT);
} else { } else {
netif_napi_add(&wil->napi_ndev, &wil->napi_rx, netif_napi_add(&wil->napi_ndev, &wil->napi_rx,
wil6210_netdev_poll_rx, wil6210_netdev_poll_rx,
WIL6210_NAPI_BUDGET); NAPI_POLL_WEIGHT);
netif_tx_napi_add(&wil->napi_ndev, netif_tx_napi_add(&wil->napi_ndev,
&wil->napi_tx, wil6210_netdev_poll_tx, &wil->napi_tx, wil6210_netdev_poll_tx,
WIL6210_NAPI_BUDGET); NAPI_POLL_WEIGHT);
} }
wil_update_net_queues_bh(wil, vif, NULL, true); wil_update_net_queues_bh(wil, vif, NULL, true);
......
...@@ -82,7 +82,6 @@ static inline u32 WIL_GET_BITS(u32 x, int b0, int b1) ...@@ -82,7 +82,6 @@ static inline u32 WIL_GET_BITS(u32 x, int b0, int b1)
#define WIL6210_MAX_TX_RINGS (24) /* HW limit */ #define WIL6210_MAX_TX_RINGS (24) /* HW limit */
#define WIL6210_MAX_CID (20) /* max number of stations */ #define WIL6210_MAX_CID (20) /* max number of stations */
#define WIL6210_RX_DESC_MAX_CID (8) /* HW limit */ #define WIL6210_RX_DESC_MAX_CID (8) /* HW limit */
#define WIL6210_NAPI_BUDGET (16) /* arbitrary */
#define WIL_MAX_AMPDU_SIZE (64 * 1024) /* FW/HW limit */ #define WIL_MAX_AMPDU_SIZE (64 * 1024) /* FW/HW limit */
#define WIL_MAX_AGG_WSIZE (32) /* FW/HW limit */ #define WIL_MAX_AGG_WSIZE (32) /* FW/HW limit */
#define WIL_MAX_AMPDU_SIZE_128 (128 * 1024) /* FW/HW limit */ #define WIL_MAX_AMPDU_SIZE_128 (128 * 1024) /* FW/HW limit */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment