Commit 3b4cfc69 authored by Evgeny Novikov's avatar Evgeny Novikov Committed by Mauro Carvalho Chehab

media: rc: return proper error code on error handling path in init

If lirc_dev_init() fails during module initialization, rc_core_init()
returns 0 denoting success. This can cause different issues during
further operation of the module. The patch fixes the return value of
rc_core_init() on the corresponding error handling path.

Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: default avatarEvgeny Novikov <novikov@ispras.ru>
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 39c2cf75
...@@ -2052,7 +2052,7 @@ static int __init rc_core_init(void) ...@@ -2052,7 +2052,7 @@ static int __init rc_core_init(void)
if (rc) { if (rc) {
pr_err("rc_core: unable to init lirc\n"); pr_err("rc_core: unable to init lirc\n");
class_unregister(&rc_class); class_unregister(&rc_class);
return 0; return rc;
} }
led_trigger_register_simple("rc-feedback", &led_feedback); led_trigger_register_simple("rc-feedback", &led_feedback);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment