Commit 3ba41621 authored by Ben Hutchings's avatar Ben Hutchings Committed by Linus Torvalds

kconfig: Avoid buffer underrun in choice input

Commit 40aee729 ('kconfig: fix default value for choice input')
fixed some cases where kconfig would select the wrong option from a
choice with a single valid option and thus enter an infinite loop.

However, this broke the test for user input of the form 'N?', because
when kconfig selects the single valid option the input is zero-length
and the test will read the byte before the input buffer.  If this
happens to contain '?' (as it will in a mips build on Debian unstable
today) then kconfig again enters an infinite loop.
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Cc: stable@kernel.org [2.6.17+]
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 686c4cbb
...@@ -332,7 +332,7 @@ static int conf_choice(struct menu *menu) ...@@ -332,7 +332,7 @@ static int conf_choice(struct menu *menu)
} }
if (!child) if (!child)
continue; continue;
if (line[strlen(line) - 1] == '?') { if (line[0] && line[strlen(line) - 1] == '?') {
print_help(child); print_help(child);
continue; continue;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment