Commit 3bbf7f46 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Rusty Russell

linux/cpumask.h: add typechecking to cpumask_test_cpu

The Subtlety (1) referred to vanished with 6ba2ef7b ("cpumask:
Move deprecated functions to end of header."). That used to mention
some suboptimal code generation by a, by now, rather ancient gcc. With
gcc 4.7, I don't see any change in the generated code by making it a
static inline, so let's add type checking and get rid of the ghost
reference.
Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent cdfdef75
...@@ -290,11 +290,11 @@ static inline void cpumask_clear_cpu(int cpu, struct cpumask *dstp) ...@@ -290,11 +290,11 @@ static inline void cpumask_clear_cpu(int cpu, struct cpumask *dstp)
* @cpumask: the cpumask pointer * @cpumask: the cpumask pointer
* *
* Returns 1 if @cpu is set in @cpumask, else returns 0 * Returns 1 if @cpu is set in @cpumask, else returns 0
*
* No static inline type checking - see Subtlety (1) above.
*/ */
#define cpumask_test_cpu(cpu, cpumask) \ static inline int cpumask_test_cpu(int cpu, const struct cpumask *cpumask)
test_bit(cpumask_check(cpu), cpumask_bits((cpumask))) {
return test_bit(cpumask_check(cpu), cpumask_bits((cpumask)));
}
/** /**
* cpumask_test_and_set_cpu - atomically test and set a cpu in a cpumask * cpumask_test_and_set_cpu - atomically test and set a cpu in a cpumask
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment