Commit 3c5e6a62 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: ni_labpc: use cfc_handle_events()

Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().

Also, remove the clearing of the events, comedi_event() does that.

In the Kconfig, COMEDI_NI_LABPC already selects COMEDI_FC.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d2881518
...@@ -947,7 +947,6 @@ static irqreturn_t labpc_interrupt(int irq, void *d) ...@@ -947,7 +947,6 @@ static irqreturn_t labpc_interrupt(int irq, void *d)
async = s->async; async = s->async;
cmd = &async->cmd; cmd = &async->cmd;
async->events = 0;
/* read board status */ /* read board status */
devpriv->stat1 = devpriv->read_byte(dev->iobase + STAT1_REG); devpriv->stat1 = devpriv->read_byte(dev->iobase + STAT1_REG);
...@@ -965,7 +964,7 @@ static irqreturn_t labpc_interrupt(int irq, void *d) ...@@ -965,7 +964,7 @@ static irqreturn_t labpc_interrupt(int irq, void *d)
/* clear error interrupt */ /* clear error interrupt */
devpriv->write_byte(0x1, dev->iobase + ADC_FIFO_CLEAR_REG); devpriv->write_byte(0x1, dev->iobase + ADC_FIFO_CLEAR_REG);
async->events |= COMEDI_CB_ERROR | COMEDI_CB_EOA; async->events |= COMEDI_CB_ERROR | COMEDI_CB_EOA;
comedi_event(dev, s); cfc_handle_events(dev, s);
comedi_error(dev, "overrun"); comedi_error(dev, "overrun");
return IRQ_HANDLED; return IRQ_HANDLED;
} }
...@@ -985,7 +984,7 @@ static irqreturn_t labpc_interrupt(int irq, void *d) ...@@ -985,7 +984,7 @@ static irqreturn_t labpc_interrupt(int irq, void *d)
/* clear error interrupt */ /* clear error interrupt */
devpriv->write_byte(0x1, dev->iobase + ADC_FIFO_CLEAR_REG); devpriv->write_byte(0x1, dev->iobase + ADC_FIFO_CLEAR_REG);
async->events |= COMEDI_CB_ERROR | COMEDI_CB_EOA; async->events |= COMEDI_CB_ERROR | COMEDI_CB_EOA;
comedi_event(dev, s); cfc_handle_events(dev, s);
comedi_error(dev, "overflow"); comedi_error(dev, "overflow");
return IRQ_HANDLED; return IRQ_HANDLED;
} }
...@@ -993,20 +992,17 @@ static irqreturn_t labpc_interrupt(int irq, void *d) ...@@ -993,20 +992,17 @@ static irqreturn_t labpc_interrupt(int irq, void *d)
if (cmd->stop_src == TRIG_EXT) { if (cmd->stop_src == TRIG_EXT) {
if (devpriv->stat2 & STAT2_OUTA1) { if (devpriv->stat2 & STAT2_OUTA1) {
labpc_drain_dregs(dev); labpc_drain_dregs(dev);
labpc_cancel(dev, s);
async->events |= COMEDI_CB_EOA; async->events |= COMEDI_CB_EOA;
} }
} }
/* TRIG_COUNT end of acquisition */ /* TRIG_COUNT end of acquisition */
if (cmd->stop_src == TRIG_COUNT) { if (cmd->stop_src == TRIG_COUNT) {
if (devpriv->count == 0) { if (devpriv->count == 0)
labpc_cancel(dev, s);
async->events |= COMEDI_CB_EOA; async->events |= COMEDI_CB_EOA;
} }
}
comedi_event(dev, s); cfc_handle_events(dev, s);
return IRQ_HANDLED; return IRQ_HANDLED;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment