Commit 3c646f2c authored by NeilBrown's avatar NeilBrown Committed by Thomas Gleixner

genirq: Don't suspend nested_thread irqs over system suspend

Nested IRQs can only fire when the parent irq fires.  So when the
parent is suspended, there is no need to suspend the child irq.

Suspending nested irqs can cause a problem is they are suspended or
resumed in the wrong order.  If an interrupt fires while the parent is
active but the child is suspended, then the interrupt will not be
acknowledged properly and so an interrupt storm can result.  This is
particularly likely if the parent is resumed before the child, and the
interrupt was raised during suspend.

Ensuring correct ordering would be possible, but it is simpler to just
never suspend nested interrupts.
Signed-off-by: default avatarNeilBrown <neil@brown.name>
Cc: GTA04 owners <gta04-owner@goldelico.com>
Cc: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
Acked-by: default avatarPeter Zijlstra <peterz@infradead.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Link: http://lkml.kernel.org/r/20150517151934.2393e8f8@notabene.brownSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 63781394
...@@ -123,6 +123,8 @@ void suspend_device_irqs(void) ...@@ -123,6 +123,8 @@ void suspend_device_irqs(void)
unsigned long flags; unsigned long flags;
bool sync; bool sync;
if (irq_settings_is_nested_thread(desc))
continue;
raw_spin_lock_irqsave(&desc->lock, flags); raw_spin_lock_irqsave(&desc->lock, flags);
sync = suspend_device_irq(desc, irq); sync = suspend_device_irq(desc, irq);
raw_spin_unlock_irqrestore(&desc->lock, flags); raw_spin_unlock_irqrestore(&desc->lock, flags);
...@@ -163,6 +165,8 @@ static void resume_irqs(bool want_early) ...@@ -163,6 +165,8 @@ static void resume_irqs(bool want_early)
if (!is_early && want_early) if (!is_early && want_early)
continue; continue;
if (irq_settings_is_nested_thread(desc))
continue;
raw_spin_lock_irqsave(&desc->lock, flags); raw_spin_lock_irqsave(&desc->lock, flags);
resume_irq(desc, irq); resume_irq(desc, irq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment