Commit 3d26759c authored by Al Viro's avatar Al Viro

r128: don't open-code memdup_user()

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent f1ee6162
...@@ -982,25 +982,14 @@ static int r128_cce_dispatch_write_pixels(struct drm_device *dev, ...@@ -982,25 +982,14 @@ static int r128_cce_dispatch_write_pixels(struct drm_device *dev,
xbuf_size = count * sizeof(*x); xbuf_size = count * sizeof(*x);
ybuf_size = count * sizeof(*y); ybuf_size = count * sizeof(*y);
x = kmalloc(xbuf_size, GFP_KERNEL); x = memdup_user(depth->x, xbuf_size);
if (x == NULL) if (IS_ERR(x))
return -ENOMEM; return PTR_ERR(x);
y = kmalloc(ybuf_size, GFP_KERNEL); y = memdup_user(depth->y, ybuf_size);
if (y == NULL) { if (IS_ERR(y)) {
kfree(x);
return -ENOMEM;
}
if (copy_from_user(x, depth->x, xbuf_size)) {
kfree(x);
kfree(y);
return -EFAULT;
}
if (copy_from_user(y, depth->y, xbuf_size)) {
kfree(x); kfree(x);
kfree(y); return PTR_ERR(y);
return -EFAULT;
} }
buffer_size = depth->n * sizeof(u32); buffer_size = depth->n * sizeof(u32);
buffer = memdup_user(depth->buffer, buffer_size); buffer = memdup_user(depth->buffer, buffer_size);
if (IS_ERR(buffer)) { if (IS_ERR(buffer)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment