Commit 3dcb00ea authored by eric miao's avatar eric miao Committed by Russell King

[ARM] pxa: use __raw_writel()/__raw_readl() for ssp_xxxx()

1. change SSP register definitions from absolute virtual addresses to
   offsets

2. use __raw_writel()/__raw_readl() for functions of ssp_xxxx()
Signed-off-by: default avatareric miao <eric.miao@marvell.com>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 0aea1fd5
...@@ -48,9 +48,11 @@ ...@@ -48,9 +48,11 @@
static irqreturn_t ssp_interrupt(int irq, void *dev_id) static irqreturn_t ssp_interrupt(int irq, void *dev_id)
{ {
struct ssp_dev *dev = (struct ssp_dev*) dev_id; struct ssp_dev *dev = (struct ssp_dev*) dev_id;
unsigned int status = SSSR_P(dev->port); struct ssp_device *ssp = dev->ssp;
unsigned int status;
SSSR_P(dev->port) = status; /* clear status bits */ status = __raw_readl(ssp->mmio_base + SSSR);
__raw_writel(status, ssp->mmio_base + SSSR);
if (status & SSSR_ROR) if (status & SSSR_ROR)
printk(KERN_WARNING "SSP(%d): receiver overrun\n", dev->port); printk(KERN_WARNING "SSP(%d): receiver overrun\n", dev->port);
...@@ -79,15 +81,16 @@ static irqreturn_t ssp_interrupt(int irq, void *dev_id) ...@@ -79,15 +81,16 @@ static irqreturn_t ssp_interrupt(int irq, void *dev_id)
*/ */
int ssp_write_word(struct ssp_dev *dev, u32 data) int ssp_write_word(struct ssp_dev *dev, u32 data)
{ {
struct ssp_device *ssp = dev->ssp;
int timeout = TIMEOUT; int timeout = TIMEOUT;
while (!(SSSR_P(dev->port) & SSSR_TNF)) { while (!(__raw_readl(ssp->mmio_base + SSSR) & SSSR_TNF)) {
if (!--timeout) if (!--timeout)
return -ETIMEDOUT; return -ETIMEDOUT;
cpu_relax(); cpu_relax();
} }
SSDR_P(dev->port) = data; __raw_writel(data, ssp->mmio_base + SSDR);
return 0; return 0;
} }
...@@ -109,15 +112,16 @@ int ssp_write_word(struct ssp_dev *dev, u32 data) ...@@ -109,15 +112,16 @@ int ssp_write_word(struct ssp_dev *dev, u32 data)
*/ */
int ssp_read_word(struct ssp_dev *dev, u32 *data) int ssp_read_word(struct ssp_dev *dev, u32 *data)
{ {
struct ssp_device *ssp = dev->ssp;
int timeout = TIMEOUT; int timeout = TIMEOUT;
while (!(SSSR_P(dev->port) & SSSR_RNE)) { while (!(__raw_readl(ssp->mmio_base + SSSR) & SSSR_RNE)) {
if (!--timeout) if (!--timeout)
return -ETIMEDOUT; return -ETIMEDOUT;
cpu_relax(); cpu_relax();
} }
*data = SSDR_P(dev->port); *data = __raw_readl(ssp->mmio_base + SSDR);
return 0; return 0;
} }
...@@ -131,17 +135,18 @@ int ssp_read_word(struct ssp_dev *dev, u32 *data) ...@@ -131,17 +135,18 @@ int ssp_read_word(struct ssp_dev *dev, u32 *data)
*/ */
int ssp_flush(struct ssp_dev *dev) int ssp_flush(struct ssp_dev *dev)
{ {
struct ssp_device *ssp = dev->ssp;
int timeout = TIMEOUT * 2; int timeout = TIMEOUT * 2;
do { do {
while (SSSR_P(dev->port) & SSSR_RNE) { while (__raw_readl(ssp->mmio_base + SSSR) & SSSR_RNE) {
if (!--timeout) if (!--timeout)
return -ETIMEDOUT; return -ETIMEDOUT;
(void) SSDR_P(dev->port); (void)__raw_readl(ssp->mmio_base + SSDR);
} }
if (!--timeout) if (!--timeout)
return -ETIMEDOUT; return -ETIMEDOUT;
} while (SSSR_P(dev->port) & SSSR_BSY); } while (__raw_readl(ssp->mmio_base + SSSR) & SSSR_BSY);
return 0; return 0;
} }
...@@ -153,7 +158,12 @@ int ssp_flush(struct ssp_dev *dev) ...@@ -153,7 +158,12 @@ int ssp_flush(struct ssp_dev *dev)
*/ */
void ssp_enable(struct ssp_dev *dev) void ssp_enable(struct ssp_dev *dev)
{ {
SSCR0_P(dev->port) |= SSCR0_SSE; struct ssp_device *ssp = dev->ssp;
uint32_t sscr0;
sscr0 = __raw_readl(ssp->mmio_base + SSCR0);
sscr0 |= SSCR0_SSE;
__raw_writel(sscr0, ssp->mmio_base + SSCR0);
} }
/** /**
...@@ -163,7 +173,12 @@ void ssp_enable(struct ssp_dev *dev) ...@@ -163,7 +173,12 @@ void ssp_enable(struct ssp_dev *dev)
*/ */
void ssp_disable(struct ssp_dev *dev) void ssp_disable(struct ssp_dev *dev)
{ {
SSCR0_P(dev->port) &= ~SSCR0_SSE; struct ssp_device *ssp = dev->ssp;
uint32_t sscr0;
sscr0 = __raw_readl(ssp->mmio_base + SSCR0);
sscr0 &= ~SSCR0_SSE;
__raw_writel(sscr0, ssp->mmio_base + SSCR0);
} }
/** /**
...@@ -172,14 +187,16 @@ void ssp_disable(struct ssp_dev *dev) ...@@ -172,14 +187,16 @@ void ssp_disable(struct ssp_dev *dev)
* *
* Save the configured SSP state for suspend. * Save the configured SSP state for suspend.
*/ */
void ssp_save_state(struct ssp_dev *dev, struct ssp_state *ssp) void ssp_save_state(struct ssp_dev *dev, struct ssp_state *state)
{ {
ssp->cr0 = SSCR0_P(dev->port); struct ssp_device *ssp = dev->ssp;
ssp->cr1 = SSCR1_P(dev->port);
ssp->to = SSTO_P(dev->port); state->cr0 = __raw_readl(ssp->mmio_base + SSCR0);
ssp->psp = SSPSP_P(dev->port); state->cr1 = __raw_readl(ssp->mmio_base + SSCR1);
state->to = __raw_readl(ssp->mmio_base + SSTO);
state->psp = __raw_readl(ssp->mmio_base + SSPSP);
SSCR0_P(dev->port) &= ~SSCR0_SSE; ssp_disable(dev);
} }
/** /**
...@@ -188,16 +205,18 @@ void ssp_save_state(struct ssp_dev *dev, struct ssp_state *ssp) ...@@ -188,16 +205,18 @@ void ssp_save_state(struct ssp_dev *dev, struct ssp_state *ssp)
* *
* Restore the SSP configuration saved previously by ssp_save_state. * Restore the SSP configuration saved previously by ssp_save_state.
*/ */
void ssp_restore_state(struct ssp_dev *dev, struct ssp_state *ssp) void ssp_restore_state(struct ssp_dev *dev, struct ssp_state *state)
{ {
SSSR_P(dev->port) = SSSR_ROR | SSSR_TUR | SSSR_BCE; struct ssp_device *ssp = dev->ssp;
uint32_t sssr = SSSR_ROR | SSSR_TUR | SSSR_BCE;
SSCR0_P(dev->port) = ssp->cr0 & ~SSCR0_SSE; __raw_writel(sssr, ssp->mmio_base + SSSR);
SSCR1_P(dev->port) = ssp->cr1;
SSTO_P(dev->port) = ssp->to;
SSPSP_P(dev->port) = ssp->psp;
SSCR0_P(dev->port) = ssp->cr0; __raw_writel(state->cr0 & ~SSCR0_SSE, ssp->mmio_base + SSCR0);
__raw_writel(state->cr1, ssp->mmio_base + SSCR1);
__raw_writel(state->to, ssp->mmio_base + SSTO);
__raw_writel(state->psp, ssp->mmio_base + SSPSP);
__raw_writel(state->cr0, ssp->mmio_base + SSCR0);
} }
/** /**
...@@ -211,15 +230,17 @@ void ssp_restore_state(struct ssp_dev *dev, struct ssp_state *ssp) ...@@ -211,15 +230,17 @@ void ssp_restore_state(struct ssp_dev *dev, struct ssp_state *ssp)
*/ */
int ssp_config(struct ssp_dev *dev, u32 mode, u32 flags, u32 psp_flags, u32 speed) int ssp_config(struct ssp_dev *dev, u32 mode, u32 flags, u32 psp_flags, u32 speed)
{ {
struct ssp_device *ssp = dev->ssp;
dev->mode = mode; dev->mode = mode;
dev->flags = flags; dev->flags = flags;
dev->psp_flags = psp_flags; dev->psp_flags = psp_flags;
dev->speed = speed; dev->speed = speed;
/* set up port type, speed, port settings */ /* set up port type, speed, port settings */
SSCR0_P(dev->port) = (dev->speed | dev->mode); __raw_writel((dev->speed | dev->mode), ssp->mmio_base + SSCR0);
SSCR1_P(dev->port) = dev->flags; __raw_writel(dev->flags, ssp->mmio_base + SSCR1);
SSPSP_P(dev->port) = dev->psp_flags; __raw_writel(dev->psp_flags, ssp->mmio_base + SSPSP);
return 0; return 0;
} }
...@@ -274,7 +295,7 @@ void ssp_exit(struct ssp_dev *dev) ...@@ -274,7 +295,7 @@ void ssp_exit(struct ssp_dev *dev)
{ {
struct ssp_device *ssp = dev->ssp; struct ssp_device *ssp = dev->ssp;
SSCR0_P(dev->port) &= ~SSCR0_SSE; ssp_disable(dev);
free_irq(dev->irq, dev); free_irq(dev->irq, dev);
clk_disable(ssp->clk); clk_disable(ssp->clk);
ssp_free(ssp); ssp_free(ssp);
......
...@@ -7,7 +7,20 @@ ...@@ -7,7 +7,20 @@
* PXA255, PXA26x and PXA27x have extra ports, registers and bits. * PXA255, PXA26x and PXA27x have extra ports, registers and bits.
*/ */
/* Common PXA2xx bits first */ #define SSCR0 (0x00) /* SSP Control Register 0 */
#define SSCR1 (0x04) /* SSP Control Register 1 */
#define SSSR (0x08) /* SSP Status Register */
#define SSITR (0x0C) /* SSP Interrupt Test Register */
#define SSDR (0x10) /* SSP Data Write/Data Read Register */
#define SSTO (0x28) /* SSP Time Out Register */
#define SSPSP (0x2C) /* SSP Programmable Serial Protocol */
#define SSTSA (0x30) /* SSP Tx Timeslot Active */
#define SSRSA (0x34) /* SSP Rx Timeslot Active */
#define SSTSS (0x38) /* SSP Timeslot Status */
#define SSACD (0x3C) /* SSP Audio Clock Divider */
/* Common PXA2xx bits first */
#define SSCR0_DSS (0x0000000f) /* Data Size Select (mask) */ #define SSCR0_DSS (0x0000000f) /* Data Size Select (mask) */
#define SSCR0_DataSize(x) ((x) - 1) /* Data Size Select [4..16] */ #define SSCR0_DataSize(x) ((x) - 1) /* Data Size Select [4..16] */
#define SSCR0_FRF (0x00000030) /* FRame Format (mask) */ #define SSCR0_FRF (0x00000030) /* FRame Format (mask) */
...@@ -96,78 +109,4 @@ ...@@ -96,78 +109,4 @@
#define SSACD_ACPS(x) ((x) << 4) /* Audio clock PLL select */ #define SSACD_ACPS(x) ((x) << 4) /* Audio clock PLL select */
#define SSACD_ACDS(x) ((x) << 0) /* Audio clock divider select */ #define SSACD_ACDS(x) ((x) << 0) /* Audio clock divider select */
#define SSCR0_P1 __REG(0x41000000) /* SSP Port 1 Control Register 0 */
#define SSCR1_P1 __REG(0x41000004) /* SSP Port 1 Control Register 1 */
#define SSSR_P1 __REG(0x41000008) /* SSP Port 1 Status Register */
#define SSITR_P1 __REG(0x4100000C) /* SSP Port 1 Interrupt Test Register */
#define SSDR_P1 __REG(0x41000010) /* (Write / Read) SSP Port 1 Data Write Register/SSP Data Read Register */
/* Support existing PXA25x drivers */
#define SSCR0 SSCR0_P1 /* SSP Control Register 0 */
#define SSCR1 SSCR1_P1 /* SSP Control Register 1 */
#define SSSR SSSR_P1 /* SSP Status Register */
#define SSITR SSITR_P1 /* SSP Interrupt Test Register */
#define SSDR SSDR_P1 /* (Write / Read) SSP Data Write Register/SSP Data Read Register */
/* PXA27x ports */
#if defined (CONFIG_PXA27x)
#define SSTO_P1 __REG(0x41000028) /* SSP Port 1 Time Out Register */
#define SSPSP_P1 __REG(0x4100002C) /* SSP Port 1 Programmable Serial Protocol */
#define SSTSA_P1 __REG(0x41000030) /* SSP Port 1 Tx Timeslot Active */
#define SSRSA_P1 __REG(0x41000034) /* SSP Port 1 Rx Timeslot Active */
#define SSTSS_P1 __REG(0x41000038) /* SSP Port 1 Timeslot Status */
#define SSACD_P1 __REG(0x4100003C) /* SSP Port 1 Audio Clock Divider */
#define SSCR0_P2 __REG(0x41700000) /* SSP Port 2 Control Register 0 */
#define SSCR1_P2 __REG(0x41700004) /* SSP Port 2 Control Register 1 */
#define SSSR_P2 __REG(0x41700008) /* SSP Port 2 Status Register */
#define SSITR_P2 __REG(0x4170000C) /* SSP Port 2 Interrupt Test Register */
#define SSDR_P2 __REG(0x41700010) /* (Write / Read) SSP Port 2 Data Write Register/SSP Data Read Register */
#define SSTO_P2 __REG(0x41700028) /* SSP Port 2 Time Out Register */
#define SSPSP_P2 __REG(0x4170002C) /* SSP Port 2 Programmable Serial Protocol */
#define SSTSA_P2 __REG(0x41700030) /* SSP Port 2 Tx Timeslot Active */
#define SSRSA_P2 __REG(0x41700034) /* SSP Port 2 Rx Timeslot Active */
#define SSTSS_P2 __REG(0x41700038) /* SSP Port 2 Timeslot Status */
#define SSACD_P2 __REG(0x4170003C) /* SSP Port 2 Audio Clock Divider */
#define SSCR0_P3 __REG(0x41900000) /* SSP Port 3 Control Register 0 */
#define SSCR1_P3 __REG(0x41900004) /* SSP Port 3 Control Register 1 */
#define SSSR_P3 __REG(0x41900008) /* SSP Port 3 Status Register */
#define SSITR_P3 __REG(0x4190000C) /* SSP Port 3 Interrupt Test Register */
#define SSDR_P3 __REG(0x41900010) /* (Write / Read) SSP Port 3 Data Write Register/SSP Data Read Register */
#define SSTO_P3 __REG(0x41900028) /* SSP Port 3 Time Out Register */
#define SSPSP_P3 __REG(0x4190002C) /* SSP Port 3 Programmable Serial Protocol */
#define SSTSA_P3 __REG(0x41900030) /* SSP Port 3 Tx Timeslot Active */
#define SSRSA_P3 __REG(0x41900034) /* SSP Port 3 Rx Timeslot Active */
#define SSTSS_P3 __REG(0x41900038) /* SSP Port 3 Timeslot Status */
#define SSACD_P3 __REG(0x4190003C) /* SSP Port 3 Audio Clock Divider */
#else /* PXA255 (only port 2) and PXA26x ports*/
#define SSTO_P1 __REG(0x41000028) /* SSP Port 1 Time Out Register */
#define SSPSP_P1 __REG(0x4100002C) /* SSP Port 1 Programmable Serial Protocol */
#define SSCR0_P2 __REG(0x41400000) /* SSP Port 2 Control Register 0 */
#define SSCR1_P2 __REG(0x41400004) /* SSP Port 2 Control Register 1 */
#define SSSR_P2 __REG(0x41400008) /* SSP Port 2 Status Register */
#define SSITR_P2 __REG(0x4140000C) /* SSP Port 2 Interrupt Test Register */
#define SSDR_P2 __REG(0x41400010) /* (Write / Read) SSP Port 2 Data Write Register/SSP Data Read Register */
#define SSTO_P2 __REG(0x41400028) /* SSP Port 2 Time Out Register */
#define SSPSP_P2 __REG(0x4140002C) /* SSP Port 2 Programmable Serial Protocol */
#define SSCR0_P3 __REG(0x41500000) /* SSP Port 3 Control Register 0 */
#define SSCR1_P3 __REG(0x41500004) /* SSP Port 3 Control Register 1 */
#define SSSR_P3 __REG(0x41500008) /* SSP Port 3 Status Register */
#define SSITR_P3 __REG(0x4150000C) /* SSP Port 3 Interrupt Test Register */
#define SSDR_P3 __REG(0x41500010) /* (Write / Read) SSP Port 3 Data Write Register/SSP Data Read Register */
#define SSTO_P3 __REG(0x41500028) /* SSP Port 3 Time Out Register */
#define SSPSP_P3 __REG(0x4150002C) /* SSP Port 3 Programmable Serial Protocol */
#endif
#define SSCR0_P(x) (*(((x) == 1) ? &SSCR0_P1 : ((x) == 2) ? &SSCR0_P2 : ((x) == 3) ? &SSCR0_P3 : NULL))
#define SSCR1_P(x) (*(((x) == 1) ? &SSCR1_P1 : ((x) == 2) ? &SSCR1_P2 : ((x) == 3) ? &SSCR1_P3 : NULL))
#define SSSR_P(x) (*(((x) == 1) ? &SSSR_P1 : ((x) == 2) ? &SSSR_P2 : ((x) == 3) ? &SSSR_P3 : NULL))
#define SSITR_P(x) (*(((x) == 1) ? &SSITR_P1 : ((x) == 2) ? &SSITR_P2 : ((x) == 3) ? &SSITR_P3 : NULL))
#define SSDR_P(x) (*(((x) == 1) ? &SSDR_P1 : ((x) == 2) ? &SSDR_P2 : ((x) == 3) ? &SSDR_P3 : NULL))
#define SSTO_P(x) (*(((x) == 1) ? &SSTO_P1 : ((x) == 2) ? &SSTO_P2 : ((x) == 3) ? &SSTO_P3 : NULL))
#define SSPSP_P(x) (*(((x) == 1) ? &SSPSP_P1 : ((x) == 2) ? &SSPSP_P2 : ((x) == 3) ? &SSPSP_P3 : NULL))
#define SSTSA_P(x) (*(((x) == 1) ? &SSTSA_P1 : ((x) == 2) ? &SSTSA_P2 : ((x) == 3) ? &SSTSA_P3 : NULL))
#define SSRSA_P(x) (*(((x) == 1) ? &SSRSA_P1 : ((x) == 2) ? &SSRSA_P2 : ((x) == 3) ? &SSRSA_P3 : NULL))
#define SSTSS_P(x) (*(((x) == 1) ? &SSTSS_P1 : ((x) == 2) ? &SSTSS_P2 : ((x) == 3) ? &SSTSS_P3 : NULL))
#define SSACD_P(x) (*(((x) == 1) ? &SSACD_P1 : ((x) == 2) ? &SSACD_P2 : ((x) == 3) ? &SSACD_P3 : NULL))
#endif /* __ASM_ARCH_REGS_SSP_H */ #endif /* __ASM_ARCH_REGS_SSP_H */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment