Commit 3dfed895 authored by Wei Yongjun's avatar Wei Yongjun Committed by Chanwoo Choi

extcon: ptn5150: Fix return value check in ptn5150_i2c_probe()

In case of error, the function devm_gpiod_get() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent 4ed754de
...@@ -240,14 +240,14 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c, ...@@ -240,14 +240,14 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
info->dev = &i2c->dev; info->dev = &i2c->dev;
info->i2c = i2c; info->i2c = i2c;
info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN); info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN);
if (!info->int_gpiod) { if (IS_ERR(info->int_gpiod)) {
dev_err(dev, "failed to get INT GPIO\n"); dev_err(dev, "failed to get INT GPIO\n");
return -EINVAL; return PTR_ERR(info->int_gpiod);
} }
info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN); info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN);
if (!info->vbus_gpiod) { if (IS_ERR(info->vbus_gpiod)) {
dev_err(dev, "failed to get VBUS GPIO\n"); dev_err(dev, "failed to get VBUS GPIO\n");
return -EINVAL; return PTR_ERR(info->vbus_gpiod);
} }
ret = gpiod_direction_output(info->vbus_gpiod, 0); ret = gpiod_direction_output(info->vbus_gpiod, 0);
if (ret) { if (ret) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment