Commit 3e15135b authored by Rob Herring's avatar Rob Herring Committed by Thomas Gleixner

sh: Kill off set_irq_flags usage

set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:

IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Acked-by: default avatarSimon Horman <horms@verge.net.au>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sh@vger.kernel.org
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Magnus Damm <magnus.damm@gmail.com>
Link: http://lkml.kernel.org/r/1440889285-5637-4-git-send-email-robh@kernel.orgSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent d17cab44
...@@ -99,15 +99,7 @@ static inline struct intc_desc_int *get_intc_desc(unsigned int irq) ...@@ -99,15 +99,7 @@ static inline struct intc_desc_int *get_intc_desc(unsigned int irq)
*/ */
static inline void activate_irq(int irq) static inline void activate_irq(int irq)
{ {
#ifdef CONFIG_ARM irq_modify_status(irq, IRQ_NOREQUEST, IRQ_NOPROBE);
/* ARM requires an extra step to clear IRQ_NOREQUEST, which it
* sets on behalf of every irq_chip. Also sets IRQ_NOPROBE.
*/
set_irq_flags(irq, IRQF_VALID);
#else
/* same effect on other architectures */
irq_set_noprobe(irq);
#endif
} }
static inline int intc_handle_int_cmp(const void *a, const void *b) static inline int intc_handle_int_cmp(const void *a, const void *b)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment