Commit 3ea06a50 authored by Seth Forshee's avatar Seth Forshee

fuse: Restrict allow_other to the superblock's namespace or a descendant

Unprivileged users are normally restricted from mounting with the
allow_other option by system policy, but this could be bypassed
for a mount done with user namespace root permissions. In such
cases allow_other should not allow users outside the userns
to access the mount as doing so would give the unprivileged user
the ability to manipulate processes it would otherwise be unable
to manipulate. Restrict allow_other to apply to users in the same
userns used at mount or a descendant of that namespace.
Signed-off-by: default avatarSeth Forshee <seth.forshee@canonical.com>
parent 3583fc57
...@@ -1018,8 +1018,14 @@ int fuse_allow_current_process(struct fuse_conn *fc) ...@@ -1018,8 +1018,14 @@ int fuse_allow_current_process(struct fuse_conn *fc)
{ {
const struct cred *cred; const struct cred *cred;
if (fc->flags & FUSE_ALLOW_OTHER) if (fc->flags & FUSE_ALLOW_OTHER) {
struct user_namespace *ns;
for (ns = current_user_ns(); ns; ns = ns->parent) {
if (ns == fc->user_ns)
return 1; return 1;
}
return 0;
}
cred = current_cred(); cred = current_cred();
if (uid_eq(cred->euid, fc->user_id) && if (uid_eq(cred->euid, fc->user_id) &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment