Commit 3f497de9 authored by Luca Coelho's avatar Luca Coelho

iwlwifi: mvm: initialize status in iwl_mvm_add_int_sta_common()

We always need to initialize the status argument to the success case
before calling iwl_mvm_send_cmd_status() or
iwl_mvm_send_cmd_pdu_status() (which calls the former) otherwise we
may get an uninitialized value back.  In this case, we use
ADD_STA_SUCCESS as success.

Fixes: 732d06e9 ("iwlwifi: mvm: add station before allocating a queue")
Reported by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 61e7d91b
...@@ -1285,7 +1285,7 @@ static int iwl_mvm_add_int_sta_common(struct iwl_mvm *mvm, ...@@ -1285,7 +1285,7 @@ static int iwl_mvm_add_int_sta_common(struct iwl_mvm *mvm,
{ {
struct iwl_mvm_add_sta_cmd cmd; struct iwl_mvm_add_sta_cmd cmd;
int ret; int ret;
u32 status; u32 status = ADD_STA_SUCCESS;
lockdep_assert_held(&mvm->mutex); lockdep_assert_held(&mvm->mutex);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment