Commit 40434a67 authored by YueHaibing's avatar YueHaibing Committed by David S. Miller

net: chelsio: Use zeroing memory allocator instead of allocator/memset

Use dma_zalloc_coherent for allocating zeroed
memory and remove unnecessary memset function.
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1a025028
...@@ -620,7 +620,7 @@ static void *alloc_ring(struct pci_dev *pdev, size_t nelem, size_t elem_size, ...@@ -620,7 +620,7 @@ static void *alloc_ring(struct pci_dev *pdev, size_t nelem, size_t elem_size,
{ {
size_t len = nelem * elem_size; size_t len = nelem * elem_size;
void *s = NULL; void *s = NULL;
void *p = dma_alloc_coherent(&pdev->dev, len, phys, GFP_KERNEL); void *p = dma_zalloc_coherent(&pdev->dev, len, phys, GFP_KERNEL);
if (!p) if (!p)
return NULL; return NULL;
...@@ -633,7 +633,6 @@ static void *alloc_ring(struct pci_dev *pdev, size_t nelem, size_t elem_size, ...@@ -633,7 +633,6 @@ static void *alloc_ring(struct pci_dev *pdev, size_t nelem, size_t elem_size,
} }
*(void **)metadata = s; *(void **)metadata = s;
} }
memset(p, 0, len);
return p; return p;
} }
......
...@@ -694,7 +694,7 @@ static void *alloc_ring(struct device *dev, size_t nelem, size_t elem_size, ...@@ -694,7 +694,7 @@ static void *alloc_ring(struct device *dev, size_t nelem, size_t elem_size,
{ {
size_t len = nelem * elem_size + stat_size; size_t len = nelem * elem_size + stat_size;
void *s = NULL; void *s = NULL;
void *p = dma_alloc_coherent(dev, len, phys, GFP_KERNEL); void *p = dma_zalloc_coherent(dev, len, phys, GFP_KERNEL);
if (!p) if (!p)
return NULL; return NULL;
...@@ -708,7 +708,6 @@ static void *alloc_ring(struct device *dev, size_t nelem, size_t elem_size, ...@@ -708,7 +708,6 @@ static void *alloc_ring(struct device *dev, size_t nelem, size_t elem_size,
} }
if (metadata) if (metadata)
*(void **)metadata = s; *(void **)metadata = s;
memset(p, 0, len);
return p; return p;
} }
......
...@@ -756,7 +756,7 @@ static void *alloc_ring(struct device *dev, size_t nelem, size_t hwsize, ...@@ -756,7 +756,7 @@ static void *alloc_ring(struct device *dev, size_t nelem, size_t hwsize,
* Allocate the hardware ring and PCI DMA bus address space for said. * Allocate the hardware ring and PCI DMA bus address space for said.
*/ */
size_t hwlen = nelem * hwsize + stat_size; size_t hwlen = nelem * hwsize + stat_size;
void *hwring = dma_alloc_coherent(dev, hwlen, busaddrp, GFP_KERNEL); void *hwring = dma_zalloc_coherent(dev, hwlen, busaddrp, GFP_KERNEL);
if (!hwring) if (!hwring)
return NULL; return NULL;
...@@ -776,11 +776,6 @@ static void *alloc_ring(struct device *dev, size_t nelem, size_t hwsize, ...@@ -776,11 +776,6 @@ static void *alloc_ring(struct device *dev, size_t nelem, size_t hwsize,
*(void **)swringp = swring; *(void **)swringp = swring;
} }
/*
* Zero out the hardware ring and return its address as our function
* value.
*/
memset(hwring, 0, hwlen);
return hwring; return hwring;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment