Commit 40dffd99 authored by Olivier Leveque's avatar Olivier Leveque Committed by Jonathan Cameron

staging: iio: adc: ad7280a: fix permission coding style issue

Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. Consider using
octal permissions '0644'. Found running checkpatch.
Signed-off-by: default avatarOlivier Leveque <o_leveque@orange.fr>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent baecc573
...@@ -560,7 +560,7 @@ static int ad7280_attr_init(struct ad7280_state *st) ...@@ -560,7 +560,7 @@ static int ad7280_attr_init(struct ad7280_state *st)
st->iio_attr[cnt].address = st->iio_attr[cnt].address =
AD7280A_DEVADDR(dev) << 8 | ch; AD7280A_DEVADDR(dev) << 8 | ch;
st->iio_attr[cnt].dev_attr.attr.mode = st->iio_attr[cnt].dev_attr.attr.mode =
S_IWUSR | S_IRUGO; 0644;
st->iio_attr[cnt].dev_attr.show = st->iio_attr[cnt].dev_attr.show =
ad7280_show_balance_sw; ad7280_show_balance_sw;
st->iio_attr[cnt].dev_attr.store = st->iio_attr[cnt].dev_attr.store =
...@@ -577,7 +577,7 @@ static int ad7280_attr_init(struct ad7280_state *st) ...@@ -577,7 +577,7 @@ static int ad7280_attr_init(struct ad7280_state *st)
AD7280A_DEVADDR(dev) << 8 | AD7280A_DEVADDR(dev) << 8 |
(AD7280A_CB1_TIMER + ch); (AD7280A_CB1_TIMER + ch);
st->iio_attr[cnt].dev_attr.attr.mode = st->iio_attr[cnt].dev_attr.attr.mode =
S_IWUSR | S_IRUGO; 0644;
st->iio_attr[cnt].dev_attr.show = st->iio_attr[cnt].dev_attr.show =
ad7280_show_balance_timer; ad7280_show_balance_timer;
st->iio_attr[cnt].dev_attr.store = st->iio_attr[cnt].dev_attr.store =
...@@ -746,26 +746,26 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) ...@@ -746,26 +746,26 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
in_voltage-voltage_thresh_low_value, in_voltage-voltage_thresh_low_value,
S_IRUGO | S_IWUSR, 0644,
ad7280_read_channel_config, ad7280_read_channel_config,
ad7280_write_channel_config, ad7280_write_channel_config,
AD7280A_CELL_UNDERVOLTAGE); AD7280A_CELL_UNDERVOLTAGE);
static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
in_voltage-voltage_thresh_high_value, in_voltage-voltage_thresh_high_value,
S_IRUGO | S_IWUSR, 0644,
ad7280_read_channel_config, ad7280_read_channel_config,
ad7280_write_channel_config, ad7280_write_channel_config,
AD7280A_CELL_OVERVOLTAGE); AD7280A_CELL_OVERVOLTAGE);
static IIO_DEVICE_ATTR(in_temp_thresh_low_value, static IIO_DEVICE_ATTR(in_temp_thresh_low_value,
S_IRUGO | S_IWUSR, 0644,
ad7280_read_channel_config, ad7280_read_channel_config,
ad7280_write_channel_config, ad7280_write_channel_config,
AD7280A_AUX_ADC_UNDERVOLTAGE); AD7280A_AUX_ADC_UNDERVOLTAGE);
static IIO_DEVICE_ATTR(in_temp_thresh_high_value, static IIO_DEVICE_ATTR(in_temp_thresh_high_value,
S_IRUGO | S_IWUSR, 0644,
ad7280_read_channel_config, ad7280_read_channel_config,
ad7280_write_channel_config, ad7280_write_channel_config,
AD7280A_AUX_ADC_OVERVOLTAGE); AD7280A_AUX_ADC_OVERVOLTAGE);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment