Commit 412c98c1 authored by Steve Cornelius's avatar Steve Cornelius Committed by Herbert Xu

crypto: caam - fix RNG buffer cache alignment

The hwrng output buffers (2) are cast inside of a a struct (caam_rng_ctx)
allocated in one DMA-tagged region. While the kernel's heap allocator
should place the overall struct on a cacheline aligned boundary, the 2
buffers contained within may not necessarily align. Consenquently, the ends
of unaligned buffers may not fully flush, and if so, stale data will be left
behind, resulting in small repeating patterns.

This fix aligns the buffers inside the struct.

Note that not all of the data inside caam_rng_ctx necessarily needs to be
DMA-tagged, only the buffers themselves require this. However, a fix would
incur the expense of error-handling bloat in the case of allocation failure.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarSteve Cornelius <steve.cornelius@freescale.com>
Signed-off-by: default avatarVictoria Milhoan <vicki.milhoan@freescale.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 6fd4b156
...@@ -56,7 +56,7 @@ ...@@ -56,7 +56,7 @@
/* Buffer, its dma address and lock */ /* Buffer, its dma address and lock */
struct buf_data { struct buf_data {
u8 buf[RN_BUF_SIZE]; u8 buf[RN_BUF_SIZE] ____cacheline_aligned;
dma_addr_t addr; dma_addr_t addr;
struct completion filled; struct completion filled;
u32 hw_desc[DESC_JOB_O_LEN]; u32 hw_desc[DESC_JOB_O_LEN];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment