Commit 41387a59 authored by Sakari Ailus's avatar Sakari Ailus Committed by Mauro Carvalho Chehab

[media] media: entity: Fix stream count check

There's a sanity check for the stream count remaining positive or zero on
error path, but instead of performing the check on the traversed entity it
is performed on the entity where traversal ends. Fix this.

Fixes: commit 3801bc7d ("[media] media: Media Controller fix to not let stream_count go negative")
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent bcb63314
...@@ -470,7 +470,7 @@ __must_check int __media_entity_pipeline_start(struct media_entity *entity, ...@@ -470,7 +470,7 @@ __must_check int __media_entity_pipeline_start(struct media_entity *entity,
while ((entity_err = media_entity_graph_walk_next(graph))) { while ((entity_err = media_entity_graph_walk_next(graph))) {
/* don't let the stream_count go negative */ /* don't let the stream_count go negative */
if (entity->stream_count > 0) { if (entity_err->stream_count > 0) {
entity_err->stream_count--; entity_err->stream_count--;
if (entity_err->stream_count == 0) if (entity_err->stream_count == 0)
entity_err->pipe = NULL; entity_err->pipe = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment