Commit 41e9a7fa authored by Al Viro's avatar Al Viro

minixfs: switch to kmap_local_page()

Again, a counterpart of Fabio's fs/sysv patch
Reviewed-by: default avatarFabio M. De Francesco <fabio.maria.de.francesco@linux.intel.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 6628f69e
...@@ -70,9 +70,8 @@ static void *dir_get_page(struct inode *dir, unsigned long n, struct page **p) ...@@ -70,9 +70,8 @@ static void *dir_get_page(struct inode *dir, unsigned long n, struct page **p)
struct page *page = read_mapping_page(mapping, n, NULL); struct page *page = read_mapping_page(mapping, n, NULL);
if (IS_ERR(page)) if (IS_ERR(page))
return ERR_CAST(page); return ERR_CAST(page);
kmap(page);
*p = page; *p = page;
return page_address(page); return kmap_local_page(page);
} }
static inline void *minix_next_entry(void *de, struct minix_sb_info *sbi) static inline void *minix_next_entry(void *de, struct minix_sb_info *sbi)
...@@ -123,13 +122,13 @@ static int minix_readdir(struct file *file, struct dir_context *ctx) ...@@ -123,13 +122,13 @@ static int minix_readdir(struct file *file, struct dir_context *ctx)
unsigned l = strnlen(name, sbi->s_namelen); unsigned l = strnlen(name, sbi->s_namelen);
if (!dir_emit(ctx, name, l, if (!dir_emit(ctx, name, l,
inumber, DT_UNKNOWN)) { inumber, DT_UNKNOWN)) {
dir_put_page(page); unmap_and_put_page(page, p);
return 0; return 0;
} }
} }
ctx->pos += chunk_size; ctx->pos += chunk_size;
} }
dir_put_page(page); unmap_and_put_page(page, kaddr);
} }
return 0; return 0;
} }
...@@ -189,7 +188,7 @@ minix_dirent *minix_find_entry(struct dentry *dentry, struct page **res_page) ...@@ -189,7 +188,7 @@ minix_dirent *minix_find_entry(struct dentry *dentry, struct page **res_page)
if (namecompare(namelen, sbi->s_namelen, name, namx)) if (namecompare(namelen, sbi->s_namelen, name, namx))
goto found; goto found;
} }
dir_put_page(page); unmap_and_put_page(page, kaddr);
} }
return NULL; return NULL;
...@@ -255,7 +254,7 @@ int minix_add_link(struct dentry *dentry, struct inode *inode) ...@@ -255,7 +254,7 @@ int minix_add_link(struct dentry *dentry, struct inode *inode)
goto out_unlock; goto out_unlock;
} }
unlock_page(page); unlock_page(page);
dir_put_page(page); unmap_and_put_page(page, kaddr);
} }
BUG(); BUG();
return -EINVAL; return -EINVAL;
...@@ -278,7 +277,7 @@ int minix_add_link(struct dentry *dentry, struct inode *inode) ...@@ -278,7 +277,7 @@ int minix_add_link(struct dentry *dentry, struct inode *inode)
mark_inode_dirty(dir); mark_inode_dirty(dir);
err = minix_handle_dirsync(dir); err = minix_handle_dirsync(dir);
out_put: out_put:
dir_put_page(page); unmap_and_put_page(page, kaddr);
return err; return err;
out_unlock: out_unlock:
unlock_page(page); unlock_page(page);
...@@ -324,7 +323,7 @@ int minix_make_empty(struct inode *inode, struct inode *dir) ...@@ -324,7 +323,7 @@ int minix_make_empty(struct inode *inode, struct inode *dir)
goto fail; goto fail;
} }
kaddr = kmap_atomic(page); kaddr = kmap_local_page(page);
memset(kaddr, 0, PAGE_SIZE); memset(kaddr, 0, PAGE_SIZE);
if (sbi->s_version == MINIX_V3) { if (sbi->s_version == MINIX_V3) {
...@@ -344,7 +343,7 @@ int minix_make_empty(struct inode *inode, struct inode *dir) ...@@ -344,7 +343,7 @@ int minix_make_empty(struct inode *inode, struct inode *dir)
de->inode = dir->i_ino; de->inode = dir->i_ino;
strcpy(de->name, ".."); strcpy(de->name, "..");
} }
kunmap_atomic(kaddr); kunmap_local(kaddr);
dir_commit_chunk(page, 0, 2 * sbi->s_dirsize); dir_commit_chunk(page, 0, 2 * sbi->s_dirsize);
err = minix_handle_dirsync(inode); err = minix_handle_dirsync(inode);
...@@ -361,11 +360,11 @@ int minix_empty_dir(struct inode * inode) ...@@ -361,11 +360,11 @@ int minix_empty_dir(struct inode * inode)
struct page *page = NULL; struct page *page = NULL;
unsigned long i, npages = dir_pages(inode); unsigned long i, npages = dir_pages(inode);
struct minix_sb_info *sbi = minix_sb(inode->i_sb); struct minix_sb_info *sbi = minix_sb(inode->i_sb);
char *name; char *name, *kaddr;
__u32 inumber; __u32 inumber;
for (i = 0; i < npages; i++) { for (i = 0; i < npages; i++) {
char *p, *kaddr, *limit; char *p, *limit;
kaddr = dir_get_page(inode, i, &page); kaddr = dir_get_page(inode, i, &page);
if (IS_ERR(kaddr)) if (IS_ERR(kaddr))
...@@ -396,12 +395,12 @@ int minix_empty_dir(struct inode * inode) ...@@ -396,12 +395,12 @@ int minix_empty_dir(struct inode * inode)
goto not_empty; goto not_empty;
} }
} }
dir_put_page(page); unmap_and_put_page(page, kaddr);
} }
return 1; return 1;
not_empty: not_empty:
dir_put_page(page); unmap_and_put_page(page, kaddr);
return 0; return 0;
} }
...@@ -455,7 +454,7 @@ ino_t minix_inode_by_name(struct dentry *dentry) ...@@ -455,7 +454,7 @@ ino_t minix_inode_by_name(struct dentry *dentry)
res = ((minix3_dirent *) de)->inode; res = ((minix3_dirent *) de)->inode;
else else
res = de->inode; res = de->inode;
dir_put_page(page); unmap_and_put_page(page, de);
} }
return res; return res;
} }
...@@ -64,11 +64,6 @@ extern int V2_minix_get_block(struct inode *, long, struct buffer_head *, int); ...@@ -64,11 +64,6 @@ extern int V2_minix_get_block(struct inode *, long, struct buffer_head *, int);
extern unsigned V1_minix_blocks(loff_t, struct super_block *); extern unsigned V1_minix_blocks(loff_t, struct super_block *);
extern unsigned V2_minix_blocks(loff_t, struct super_block *); extern unsigned V2_minix_blocks(loff_t, struct super_block *);
static inline void dir_put_page(struct page *page)
{
kunmap(page);
put_page(page);
}
extern struct minix_dir_entry *minix_find_entry(struct dentry*, struct page**); extern struct minix_dir_entry *minix_find_entry(struct dentry*, struct page**);
extern int minix_add_link(struct dentry*, struct inode*); extern int minix_add_link(struct dentry*, struct inode*);
extern int minix_delete_entry(struct minix_dir_entry*, struct page*); extern int minix_delete_entry(struct minix_dir_entry*, struct page*);
......
...@@ -149,7 +149,7 @@ static int minix_unlink(struct inode * dir, struct dentry *dentry) ...@@ -149,7 +149,7 @@ static int minix_unlink(struct inode * dir, struct dentry *dentry)
if (!de) if (!de)
return -ENOENT; return -ENOENT;
err = minix_delete_entry(de, page); err = minix_delete_entry(de, page);
dir_put_page(page); unmap_and_put_page(page, de);
if (err) if (err)
return err; return err;
...@@ -242,9 +242,9 @@ static int minix_rename(struct mnt_idmap *idmap, ...@@ -242,9 +242,9 @@ static int minix_rename(struct mnt_idmap *idmap,
} }
out_dir: out_dir:
if (dir_de) if (dir_de)
dir_put_page(dir_page); unmap_and_put_page(dir_page, dir_de);
out_old: out_old:
dir_put_page(old_page); unmap_and_put_page(old_page, old_de);
out: out:
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment