Commit 4230e2de authored by Zong Li's avatar Zong Li Committed by Thomas Gleixner

stop_machine, rcu: Mark functions as notrace

Some architectures assume that the stopped CPUs don't make function calls
to traceable functions when they are in the stopped state. See also commit
cb9d7fd5 ("watchdog: Mark watchdog touch functions as notrace").

Violating this assumption causes kernel crashes when switching tracer on
RISC-V.

Mark rcu_momentary_dyntick_idle() and stop_machine_yield() notrace to
prevent this.

Fixes: 4ecf0a43 ("processor: get rid of cpu_relax_yield")
Fixes: 366237e7 ("stop_machine: Provide RCU quiescent state in multi_cpu_stop()")
Signed-off-by: default avatarZong Li <zong.li@sifive.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarAtish Patra <atish.patra@wdc.com>
Tested-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: default avatarPaul E. McKenney <paulmck@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201021073839.43935-1-zong.li@sifive.com
parent 3650b228
...@@ -409,7 +409,7 @@ bool rcu_eqs_special_set(int cpu) ...@@ -409,7 +409,7 @@ bool rcu_eqs_special_set(int cpu)
* *
* The caller must have disabled interrupts and must not be idle. * The caller must have disabled interrupts and must not be idle.
*/ */
void rcu_momentary_dyntick_idle(void) notrace void rcu_momentary_dyntick_idle(void)
{ {
int special; int special;
......
...@@ -178,7 +178,7 @@ static void ack_state(struct multi_stop_data *msdata) ...@@ -178,7 +178,7 @@ static void ack_state(struct multi_stop_data *msdata)
set_state(msdata, msdata->state + 1); set_state(msdata, msdata->state + 1);
} }
void __weak stop_machine_yield(const struct cpumask *cpumask) notrace void __weak stop_machine_yield(const struct cpumask *cpumask)
{ {
cpu_relax(); cpu_relax();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment