Commit 42b607da authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

NFSv4.1: integer overflow in decode_cb_sequence_args()

commit 0439f31c upstream.

This seems like it could overflow on 32 bits.  Use kmalloc_array() which
has overflow protection built in.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Cc: Rui Xiang <rui.xiang@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ca36e74e
...@@ -455,7 +455,7 @@ static __be32 decode_cb_sequence_args(struct svc_rqst *rqstp, ...@@ -455,7 +455,7 @@ static __be32 decode_cb_sequence_args(struct svc_rqst *rqstp,
args->csa_nrclists = ntohl(*p++); args->csa_nrclists = ntohl(*p++);
args->csa_rclists = NULL; args->csa_rclists = NULL;
if (args->csa_nrclists) { if (args->csa_nrclists) {
args->csa_rclists = kmalloc(args->csa_nrclists * args->csa_rclists = kmalloc_array(args->csa_nrclists,
sizeof(*args->csa_rclists), sizeof(*args->csa_rclists),
GFP_KERNEL); GFP_KERNEL);
if (unlikely(args->csa_rclists == NULL)) if (unlikely(args->csa_rclists == NULL))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment