Commit 42d2e780 authored by Asaf Vertz's avatar Asaf Vertz Committed by Herbert Xu

crypto: omap-des - fix BUG_ON condition

dd->total is unsigned so it won't do any good to check for negative
value after subtracting instead of that we should check if the
subtracted value is bigger than him

This was partially found by using a static code analysis program
called cppcheck.
Signed-off-by: default avatarAsaf Vertz <asaf.vertz@tandemg.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 28c29f56
...@@ -965,9 +965,9 @@ static irqreturn_t omap_des_irq(int irq, void *dev_id) ...@@ -965,9 +965,9 @@ static irqreturn_t omap_des_irq(int irq, void *dev_id)
} }
} }
dd->total -= DES_BLOCK_SIZE; BUG_ON(dd->total < DES_BLOCK_SIZE);
BUG_ON(dd->total < 0); dd->total -= DES_BLOCK_SIZE;
/* Clear IRQ status */ /* Clear IRQ status */
status &= ~DES_REG_IRQ_DATA_OUT; status &= ~DES_REG_IRQ_DATA_OUT;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment