Commit 42e3d611 authored by Tilman Schmidt's avatar Tilman Schmidt Committed by David S. Miller

gigaset: fix possible oops in error handling

Use pr_warning() / pr_err() instead of dev_warn() / dev_err() in two
places where the dev pointer isn't guaranteed to be valid.

Impact: error handling bugfix
Signed-off-by: default avatarTilman Schmidt <tilman@imap.cc>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 528efc6a
...@@ -599,8 +599,7 @@ void gigaset_if_init(struct cardstate *cs) ...@@ -599,8 +599,7 @@ void gigaset_if_init(struct cardstate *cs)
if (!IS_ERR(cs->tty_dev)) if (!IS_ERR(cs->tty_dev))
dev_set_drvdata(cs->tty_dev, cs); dev_set_drvdata(cs->tty_dev, cs);
else { else {
dev_warn(cs->dev, pr_warning("could not register device to the tty subsystem\n");
"could not register device to the tty subsystem\n");
cs->tty_dev = NULL; cs->tty_dev = NULL;
} }
mutex_unlock(&cs->mutex); mutex_unlock(&cs->mutex);
......
...@@ -79,5 +79,5 @@ void gigaset_init_dev_sysfs(struct cardstate *cs) ...@@ -79,5 +79,5 @@ void gigaset_init_dev_sysfs(struct cardstate *cs)
gig_dbg(DEBUG_INIT, "setting up sysfs"); gig_dbg(DEBUG_INIT, "setting up sysfs");
if (device_create_file(cs->tty_dev, &dev_attr_cidmode)) if (device_create_file(cs->tty_dev, &dev_attr_cidmode))
dev_err(cs->dev, "could not create sysfs attribute\n"); pr_err("could not create sysfs attribute\n");
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment