Commit 42f4046b authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Ard Biesheuvel

efi: use default_groups in kobj_type

There are currently 2 ways to create a set of sysfs files for a
kobj_type, through the default_attrs field, and the default_groups
field.  Move the firmware efi sysfs code to use default_groups
field which has been the preferred way since aa30f47c ("kobject: Add
support for default attribute groups to kobj_type") so that we can soon
get rid of the obsolete default_attrs field.

Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent f046fff8
...@@ -352,11 +352,12 @@ static struct attribute *def_attrs[] = { ...@@ -352,11 +352,12 @@ static struct attribute *def_attrs[] = {
&efivar_attr_raw_var.attr, &efivar_attr_raw_var.attr,
NULL, NULL,
}; };
ATTRIBUTE_GROUPS(def);
static struct kobj_type efivar_ktype = { static struct kobj_type efivar_ktype = {
.release = efivar_release, .release = efivar_release,
.sysfs_ops = &efivar_attr_ops, .sysfs_ops = &efivar_attr_ops,
.default_attrs = def_attrs, .default_groups = def_groups,
}; };
static ssize_t efivar_create(struct file *filp, struct kobject *kobj, static ssize_t efivar_create(struct file *filp, struct kobject *kobj,
......
...@@ -146,6 +146,8 @@ static struct attribute *esre1_attrs[] = { ...@@ -146,6 +146,8 @@ static struct attribute *esre1_attrs[] = {
&esre_last_attempt_status.attr, &esre_last_attempt_status.attr,
NULL NULL
}; };
ATTRIBUTE_GROUPS(esre1);
static void esre_release(struct kobject *kobj) static void esre_release(struct kobject *kobj)
{ {
struct esre_entry *entry = to_entry(kobj); struct esre_entry *entry = to_entry(kobj);
...@@ -157,7 +159,7 @@ static void esre_release(struct kobject *kobj) ...@@ -157,7 +159,7 @@ static void esre_release(struct kobject *kobj)
static struct kobj_type esre1_ktype = { static struct kobj_type esre1_ktype = {
.release = esre_release, .release = esre_release,
.sysfs_ops = &esre_attr_ops, .sysfs_ops = &esre_attr_ops,
.default_attrs = esre1_attrs, .default_groups = esre1_groups,
}; };
......
...@@ -79,6 +79,7 @@ static struct attribute *def_attrs[] = { ...@@ -79,6 +79,7 @@ static struct attribute *def_attrs[] = {
&map_attribute_attr.attr, &map_attribute_attr.attr,
NULL NULL
}; };
ATTRIBUTE_GROUPS(def);
static const struct sysfs_ops map_attr_ops = { static const struct sysfs_ops map_attr_ops = {
.show = map_attr_show, .show = map_attr_show,
...@@ -94,7 +95,7 @@ static void map_release(struct kobject *kobj) ...@@ -94,7 +95,7 @@ static void map_release(struct kobject *kobj)
static struct kobj_type __refdata map_ktype = { static struct kobj_type __refdata map_ktype = {
.sysfs_ops = &map_attr_ops, .sysfs_ops = &map_attr_ops,
.default_attrs = def_attrs, .default_groups = def_groups,
.release = map_release, .release = map_release,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment