Commit 43052741 authored by Roman Mashak's avatar Roman Mashak Committed by David S. Miller

net sched actions: avoid bitwise operation on signed value in pedit

Since char can be unsigned or signed, and bitwise operators may have
implementation-dependent results when performed on signed operands,
declare 'u8 *' operand instead.
Suggested-by: default avatarDavide Caratti <dcaratti@redhat.com>
Signed-off-by: default avatarRoman Mashak <mrv@mojatatu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 95b0d2dc
...@@ -311,7 +311,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a, ...@@ -311,7 +311,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
} }
if (tkey->offmask) { if (tkey->offmask) {
char *d, _d; u8 *d, _d;
if (!offset_valid(skb, hoffset + tkey->at)) { if (!offset_valid(skb, hoffset + tkey->at)) {
pr_info("tc action pedit 'at' offset %d out of bounds\n", pr_info("tc action pedit 'at' offset %d out of bounds\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment