Commit 44acedb0 authored by Peter Oh's avatar Peter Oh Committed by Kalle Valo

ath: use PRI value given by spec for fixed PRI

PRI value is used as divider when DFS detector analyzes candidate
radar pulses.
If PRI deviation is big from its origin PRI, DFS detector could miss
valid radar reports since HW often misses detecting radar pulses and
causes long interval value of pulses.

For instance from practical results, if runtime PRI is calculated as
1431 for fixed PRI value of 1428 and delta timestamp logs 15719,
the modular remainder will be 1409 and the delta between the remainder
and runtime PRI is 22 that is bigger than PRI tolerance which is 16.
As a result this radar report will be ignored even though it's valid.

By using spec defined PRI for fixed PRI, we can correct this error.
Signed-off-by: default avatarPeter Oh <poh@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent b0b25227
...@@ -21,12 +21,6 @@ ...@@ -21,12 +21,6 @@
#include "dfs_pri_detector.h" #include "dfs_pri_detector.h"
#include "ath.h" #include "ath.h"
/*
* tolerated deviation of radar time stamp in usecs on both sides
* TODO: this might need to be HW-dependent
*/
#define PRI_TOLERANCE 16
/** /**
* struct radar_types - contains array of patterns defined for one DFS domain * struct radar_types - contains array of patterns defined for one DFS domain
* @domain: DFS regulatory domain * @domain: DFS regulatory domain
......
...@@ -21,6 +21,11 @@ ...@@ -21,6 +21,11 @@
#include <linux/list.h> #include <linux/list.h>
#include <linux/nl80211.h> #include <linux/nl80211.h>
/* tolerated deviation of radar time stamp in usecs on both sides
* TODO: this might need to be HW-dependent
*/
#define PRI_TOLERANCE 16
/** /**
* struct ath_dfs_pool_stats - DFS Statistics for global pools * struct ath_dfs_pool_stats - DFS Statistics for global pools
*/ */
......
...@@ -25,6 +25,9 @@ struct ath_dfs_pool_stats global_dfs_pool_stats = {}; ...@@ -25,6 +25,9 @@ struct ath_dfs_pool_stats global_dfs_pool_stats = {};
#define DFS_POOL_STAT_INC(c) (global_dfs_pool_stats.c++) #define DFS_POOL_STAT_INC(c) (global_dfs_pool_stats.c++)
#define DFS_POOL_STAT_DEC(c) (global_dfs_pool_stats.c--) #define DFS_POOL_STAT_DEC(c) (global_dfs_pool_stats.c--)
#define GET_PRI_TO_USE(MIN, MAX, RUNTIME) \
(MIN + PRI_TOLERANCE == MAX - PRI_TOLERANCE ? \
MIN + PRI_TOLERANCE : RUNTIME)
/** /**
* struct pulse_elem - elements in pulse queue * struct pulse_elem - elements in pulse queue
...@@ -243,7 +246,8 @@ static bool pseq_handler_create_sequences(struct pri_detector *pde, ...@@ -243,7 +246,8 @@ static bool pseq_handler_create_sequences(struct pri_detector *pde,
ps.count_falses = 0; ps.count_falses = 0;
ps.first_ts = p->ts; ps.first_ts = p->ts;
ps.last_ts = ts; ps.last_ts = ts;
ps.pri = ts - p->ts; ps.pri = GET_PRI_TO_USE(pde->rs->pri_min,
pde->rs->pri_max, ts - p->ts);
ps.dur = ps.pri * (pde->rs->ppb - 1) ps.dur = ps.pri * (pde->rs->ppb - 1)
+ 2 * pde->rs->max_pri_tolerance; + 2 * pde->rs->max_pri_tolerance;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment