Commit 44e5194b authored by Anand Jain's avatar Anand Jain Committed by David Sterba

btrfs: drop local copy of inode i_mode

There isn't real use of making struct inode::i_mode a local copy, it
saves a dereference one time, not much. Just use it directly.
Signed-off-by: default avatarAnand Jain <anand.jain@oracle.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 3c8d8b63
...@@ -189,7 +189,6 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg) ...@@ -189,7 +189,6 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg)
struct btrfs_trans_handle *trans; struct btrfs_trans_handle *trans;
unsigned int fsflags; unsigned int fsflags;
int ret; int ret;
umode_t mode;
const char *comp = NULL; const char *comp = NULL;
u32 binode_flags = binode->flags; u32 binode_flags = binode->flags;
...@@ -212,8 +211,6 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg) ...@@ -212,8 +211,6 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg)
inode_lock(inode); inode_lock(inode);
mode = inode->i_mode;
fsflags = btrfs_mask_fsflags_for_type(inode, fsflags); fsflags = btrfs_mask_fsflags_for_type(inode, fsflags);
if ((fsflags ^ btrfs_inode_flags_to_fsflags(binode->flags)) & if ((fsflags ^ btrfs_inode_flags_to_fsflags(binode->flags)) &
(FS_APPEND_FL | FS_IMMUTABLE_FL)) { (FS_APPEND_FL | FS_IMMUTABLE_FL)) {
...@@ -248,7 +245,7 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg) ...@@ -248,7 +245,7 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg)
else else
binode_flags &= ~BTRFS_INODE_DIRSYNC; binode_flags &= ~BTRFS_INODE_DIRSYNC;
if (fsflags & FS_NOCOW_FL) { if (fsflags & FS_NOCOW_FL) {
if (S_ISREG(mode)) { if (S_ISREG(inode->i_mode)) {
/* /*
* It's safe to turn csums off here, no extents exist. * It's safe to turn csums off here, no extents exist.
* Otherwise we want the flag to reflect the real COW * Otherwise we want the flag to reflect the real COW
...@@ -264,7 +261,7 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg) ...@@ -264,7 +261,7 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg)
/* /*
* Revert back under same assumptions as above * Revert back under same assumptions as above
*/ */
if (S_ISREG(mode)) { if (S_ISREG(inode->i_mode)) {
if (inode->i_size == 0) if (inode->i_size == 0)
binode_flags &= ~(BTRFS_INODE_NODATACOW | binode_flags &= ~(BTRFS_INODE_NODATACOW |
BTRFS_INODE_NODATASUM); BTRFS_INODE_NODATASUM);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment