Commit 4640a3f2 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

FMC: fix error handling in probe() function

The call to kzalloc() wasn't checked.
The dev_info() message dereferenced freed memory on error.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarAlessandro Rubini <rubini@gnudd.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c2955da0
...@@ -136,6 +136,8 @@ static int fc_probe(struct fmc_device *fmc) ...@@ -136,6 +136,8 @@ static int fc_probe(struct fmc_device *fmc)
/* Create a char device: we want to create it anew */ /* Create a char device: we want to create it anew */
fc = kzalloc(sizeof(*fc), GFP_KERNEL); fc = kzalloc(sizeof(*fc), GFP_KERNEL);
if (!fc)
return -ENOMEM;
fc->fmc = fmc; fc->fmc = fmc;
fc->misc.minor = MISC_DYNAMIC_MINOR; fc->misc.minor = MISC_DYNAMIC_MINOR;
fc->misc.fops = &fc_fops; fc->misc.fops = &fc_fops;
...@@ -143,15 +145,18 @@ static int fc_probe(struct fmc_device *fmc) ...@@ -143,15 +145,18 @@ static int fc_probe(struct fmc_device *fmc)
spin_lock(&fc_lock); spin_lock(&fc_lock);
ret = misc_register(&fc->misc); ret = misc_register(&fc->misc);
if (ret < 0) { if (ret < 0)
kfree(fc->misc.name); goto err_unlock;
kfree(fc); list_add(&fc->list, &fc_devices);
} else {
list_add(&fc->list, &fc_devices);
}
spin_unlock(&fc_lock); spin_unlock(&fc_lock);
dev_info(&fc->fmc->dev, "Created misc device \"%s\"\n", dev_info(&fc->fmc->dev, "Created misc device \"%s\"\n",
fc->misc.name); fc->misc.name);
return 0;
err_unlock:
spin_unlock(&fc_lock);
kfree(fc->misc.name);
kfree(fc);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment