Commit 464b500e authored by Paul Walmsley's avatar Paul Walmsley Committed by Hans-Christian Egtvedt

avr32: favr-32: clk_round_rate() can return a zero upon error

Treat both negative and zero return values from clk_round_rate() as
errors.  This is needed since subsequent patches will convert
clk_round_rate()'s return value to be an unsigned type, rather than a
signed type, since some clock sources can generate rates higher than
(2^31)-1 Hz.

Eventually, when calling clk_round_rate(), only a return value of zero
will be considered a error.  All other values will be considered valid
rates.  The comparison against values less than 0 is kept to preserve
the correct behavior in the meantime.
Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Håvard Skinnemoen <hskinnemoen@gmail.com>
Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Acked-by: default avatarHans-Christian Egtvedt <egtvedt@samfundet.no>
parent 7155530d
...@@ -298,8 +298,10 @@ static int __init set_abdac_rate(struct platform_device *pdev) ...@@ -298,8 +298,10 @@ static int __init set_abdac_rate(struct platform_device *pdev)
*/ */
retval = clk_round_rate(pll1, retval = clk_round_rate(pll1,
CONFIG_BOARD_FAVR32_ABDAC_RATE * 256 * 16); CONFIG_BOARD_FAVR32_ABDAC_RATE * 256 * 16);
if (retval < 0) if (retval <= 0) {
retval = -EINVAL;
goto out_abdac; goto out_abdac;
}
retval = clk_set_rate(pll1, retval); retval = clk_set_rate(pll1, retval);
if (retval != 0) if (retval != 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment