Commit 465e9ef5 authored by Johan Hovold's avatar Johan Hovold Committed by Ben Hutchings

USB: serial: ch341: fix open error handling

commit f2950b78 upstream.

Make sure to stop the interrupt URB before returning on errors during
open.

Fixes: 664d5df9 ("USB: usb-serial ch341: support for DTR/RTS/CTS")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent bd6c1ecb
...@@ -318,7 +318,7 @@ static int ch341_open(struct tty_struct *tty, struct usb_serial_port *port) ...@@ -318,7 +318,7 @@ static int ch341_open(struct tty_struct *tty, struct usb_serial_port *port)
r = ch341_configure(serial->dev, priv); r = ch341_configure(serial->dev, priv);
if (r) if (r)
goto out; return r;
if (tty) if (tty)
ch341_set_termios(tty, port, NULL); ch341_set_termios(tty, port, NULL);
...@@ -328,12 +328,19 @@ static int ch341_open(struct tty_struct *tty, struct usb_serial_port *port) ...@@ -328,12 +328,19 @@ static int ch341_open(struct tty_struct *tty, struct usb_serial_port *port)
if (r) { if (r) {
dev_err(&port->dev, "%s - failed to submit interrupt urb: %d\n", dev_err(&port->dev, "%s - failed to submit interrupt urb: %d\n",
__func__, r); __func__, r);
goto out; return r;
} }
r = usb_serial_generic_open(tty, port); r = usb_serial_generic_open(tty, port);
if (r)
goto err_kill_interrupt_urb;
out: return r; return 0;
err_kill_interrupt_urb:
usb_kill_urb(port->interrupt_in_urb);
return r;
} }
/* Old_termios contains the original termios settings and /* Old_termios contains the original termios settings and
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment