Commit 470dbef5 authored by Tiwei Bie's avatar Tiwei Bie Committed by Richard Weinberger

um: Remove unused do_get_thread_area function

It's not used since it was introduced by commit aa6758d4 ("[PATCH]
uml: implement {get,set}_thread_area for i386"). Now, it's causing a
-Wmissing-prototypes warning:

arch/x86/um/tls_32.c:39:5: warning: no previous prototype for ‘do_get_thread_area’ [-Wmissing-prototypes]
   39 | int do_get_thread_area(struct user_desc *info)
      |     ^~~~~~~~~~~~~~~~~~

The original author also had doubts about whether it should be used.
Considering that 18 years have passed, let's just remove it.
Signed-off-by: default avatarTiwei Bie <tiwei.btw@antgroup.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent 67c3c7de
...@@ -36,22 +36,6 @@ static int do_set_thread_area(struct user_desc *info) ...@@ -36,22 +36,6 @@ static int do_set_thread_area(struct user_desc *info)
return ret; return ret;
} }
int do_get_thread_area(struct user_desc *info)
{
int ret;
u32 cpu;
cpu = get_cpu();
ret = os_get_thread_area(info, userspace_pid[cpu]);
put_cpu();
if (ret)
printk(KERN_ERR "PTRACE_GET_THREAD_AREA failed, err = %d, "
"index = %d\n", ret, info->entry_number);
return ret;
}
/* /*
* sys_get_thread_area: get a yet unused TLS descriptor index. * sys_get_thread_area: get a yet unused TLS descriptor index.
* XXX: Consider leaving one free slot for glibc usage at first place. This must * XXX: Consider leaving one free slot for glibc usage at first place. This must
...@@ -231,7 +215,6 @@ int arch_set_tls(struct task_struct *new, unsigned long tls) ...@@ -231,7 +215,6 @@ int arch_set_tls(struct task_struct *new, unsigned long tls)
return ret; return ret;
} }
/* XXX: use do_get_thread_area to read the host value? I'm not at all sure! */
static int get_tls_entry(struct task_struct *task, struct user_desc *info, static int get_tls_entry(struct task_struct *task, struct user_desc *info,
int idx) int idx)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment