Commit 47cdc11d authored by Jan Kara's avatar Jan Kara

quota: Remove locking for reading from the old quota format

The old quota format has fixed offset in quota file based on ID so
there's no locking needed against concurrent modifications of the file
(locking against concurrent IO on the same dquot is still provided by
dq_lock).
Reviewed-by: default avatarAndreas Dilger <adilger@dilger.ca>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent e342e38d
...@@ -61,7 +61,6 @@ static int v1_read_dqblk(struct dquot *dquot) ...@@ -61,7 +61,6 @@ static int v1_read_dqblk(struct dquot *dquot)
if (!dqopt->files[type]) if (!dqopt->files[type])
return -EINVAL; return -EINVAL;
down_read(&dqopt->dqio_sem);
/* Set structure to 0s in case read fails/is after end of file */ /* Set structure to 0s in case read fails/is after end of file */
memset(&dqblk, 0, sizeof(struct v1_disk_dqblk)); memset(&dqblk, 0, sizeof(struct v1_disk_dqblk));
dquot->dq_sb->s_op->quota_read(dquot->dq_sb, type, (char *)&dqblk, dquot->dq_sb->s_op->quota_read(dquot->dq_sb, type, (char *)&dqblk,
...@@ -75,7 +74,6 @@ static int v1_read_dqblk(struct dquot *dquot) ...@@ -75,7 +74,6 @@ static int v1_read_dqblk(struct dquot *dquot)
dquot->dq_dqb.dqb_isoftlimit == 0) dquot->dq_dqb.dqb_isoftlimit == 0)
set_bit(DQ_FAKE_B, &dquot->dq_flags); set_bit(DQ_FAKE_B, &dquot->dq_flags);
dqstats_inc(DQST_READS); dqstats_inc(DQST_READS);
up_read(&dqopt->dqio_sem);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment