Commit 485e9605 authored by Jeff Layton's avatar Jeff Layton Committed by Linus Torvalds

fs/buffer.c: record blockdev write errors in super_block that it backs

When syncing out a block device (a'la __sync_blockdev), any error
encountered will only be recorded in the bd_inode's mapping.  When the
blockdev contains a filesystem however, we'd like to also record the
error in the super_block that's stored there.

Make mark_buffer_write_io_error also record the error in the
corresponding super_block when a writeback error occurs and the block
device contains a mounted superblock.

Since superblocks are RCU freed, hold the rcu_read_lock to ensure that
the superblock doesn't go away while we're marking it.
Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andres Freund <andres@anarazel.de>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>
Link: http://lkml.kernel.org/r/20200428135155.19223-3-jlayton@kernel.orgSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 735e4ae5
...@@ -1154,12 +1154,19 @@ EXPORT_SYMBOL(mark_buffer_dirty); ...@@ -1154,12 +1154,19 @@ EXPORT_SYMBOL(mark_buffer_dirty);
void mark_buffer_write_io_error(struct buffer_head *bh) void mark_buffer_write_io_error(struct buffer_head *bh)
{ {
struct super_block *sb;
set_buffer_write_io_error(bh); set_buffer_write_io_error(bh);
/* FIXME: do we need to set this in both places? */ /* FIXME: do we need to set this in both places? */
if (bh->b_page && bh->b_page->mapping) if (bh->b_page && bh->b_page->mapping)
mapping_set_error(bh->b_page->mapping, -EIO); mapping_set_error(bh->b_page->mapping, -EIO);
if (bh->b_assoc_map) if (bh->b_assoc_map)
mapping_set_error(bh->b_assoc_map, -EIO); mapping_set_error(bh->b_assoc_map, -EIO);
rcu_read_lock();
sb = READ_ONCE(bh->b_bdev->bd_super);
if (sb)
errseq_set(&sb->s_wb_err, -EIO);
rcu_read_unlock();
} }
EXPORT_SYMBOL(mark_buffer_write_io_error); EXPORT_SYMBOL(mark_buffer_write_io_error);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment