Commit 4977ab6e authored by Linus Torvalds's avatar Linus Torvalds

Merge branch 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

Pull objtool relocation fixes from Ingo Molnar:
 "Two fixes related to the module loading regression introduced by the
  recent objtool changes"

* 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  objtool, modules: Discard objtool annotation sections for modules
  objtool, compiler.h: Fix __unreachable section relocation size
parents 8f03cf50 e390f9a9
...@@ -345,8 +345,6 @@ SECTIONS ...@@ -345,8 +345,6 @@ SECTIONS
DISCARDS DISCARDS
/DISCARD/ : { /DISCARD/ : {
*(.eh_frame) *(.eh_frame)
*(__func_stack_frame_non_standard)
*(__unreachable)
} }
} }
......
...@@ -200,8 +200,8 @@ ...@@ -200,8 +200,8 @@
#ifdef CONFIG_STACK_VALIDATION #ifdef CONFIG_STACK_VALIDATION
#define annotate_unreachable() ({ \ #define annotate_unreachable() ({ \
asm("%c0:\t\n" \ asm("%c0:\t\n" \
".pushsection __unreachable, \"a\"\t\n" \ ".pushsection .discard.unreachable\t\n" \
".long %c0b\t\n" \ ".long %c0b - .\t\n" \
".popsection\t\n" : : "i" (__LINE__)); \ ".popsection\t\n" : : "i" (__LINE__)); \
}) })
#else #else
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
* For more information, see tools/objtool/Documentation/stack-validation.txt. * For more information, see tools/objtool/Documentation/stack-validation.txt.
*/ */
#define STACK_FRAME_NON_STANDARD(func) \ #define STACK_FRAME_NON_STANDARD(func) \
static void __used __section(__func_stack_frame_non_standard) \ static void __used __section(.discard.func_stack_frame_non_standard) \
*__func_stack_frame_non_standard_##func = func *__func_stack_frame_non_standard_##func = func
#else /* !CONFIG_STACK_VALIDATION */ #else /* !CONFIG_STACK_VALIDATION */
......
...@@ -854,6 +854,7 @@ static const char *const section_white_list[] = ...@@ -854,6 +854,7 @@ static const char *const section_white_list[] =
".cmem*", /* EZchip */ ".cmem*", /* EZchip */
".fmt_slot*", /* EZchip */ ".fmt_slot*", /* EZchip */
".gnu.lto*", ".gnu.lto*",
".discard.*",
NULL NULL
}; };
......
...@@ -4,7 +4,10 @@ ...@@ -4,7 +4,10 @@
* combine them automatically. * combine them automatically.
*/ */
SECTIONS { SECTIONS {
/DISCARD/ : { *(.discard) } /DISCARD/ : {
*(.discard)
*(.discard.*)
}
__ksymtab 0 : { *(SORT(___ksymtab+*)) } __ksymtab 0 : { *(SORT(___ksymtab+*)) }
__ksymtab_gpl 0 : { *(SORT(___ksymtab_gpl+*)) } __ksymtab_gpl 0 : { *(SORT(___ksymtab_gpl+*)) }
......
...@@ -339,13 +339,13 @@ static int add_dead_ends(struct objtool_file *file) ...@@ -339,13 +339,13 @@ static int add_dead_ends(struct objtool_file *file)
struct instruction *insn; struct instruction *insn;
bool found; bool found;
sec = find_section_by_name(file->elf, ".rela__unreachable"); sec = find_section_by_name(file->elf, ".rela.discard.unreachable");
if (!sec) if (!sec)
return 0; return 0;
list_for_each_entry(rela, &sec->rela_list, list) { list_for_each_entry(rela, &sec->rela_list, list) {
if (rela->sym->type != STT_SECTION) { if (rela->sym->type != STT_SECTION) {
WARN("unexpected relocation symbol type in .rela__unreachable"); WARN("unexpected relocation symbol type in %s", sec->name);
return -1; return -1;
} }
insn = find_insn(file, rela->sym->sec, rela->addend); insn = find_insn(file, rela->sym->sec, rela->addend);
...@@ -1272,7 +1272,7 @@ int cmd_check(int argc, const char **argv) ...@@ -1272,7 +1272,7 @@ int cmd_check(int argc, const char **argv)
INIT_LIST_HEAD(&file.insn_list); INIT_LIST_HEAD(&file.insn_list);
hash_init(file.insn_hash); hash_init(file.insn_hash);
file.whitelist = find_section_by_name(file.elf, "__func_stack_frame_non_standard"); file.whitelist = find_section_by_name(file.elf, ".discard.func_stack_frame_non_standard");
file.rodata = find_section_by_name(file.elf, ".rodata"); file.rodata = find_section_by_name(file.elf, ".rodata");
file.ignore_unreachables = false; file.ignore_unreachables = false;
file.c_file = find_section_by_name(file.elf, ".comment"); file.c_file = find_section_by_name(file.elf, ".comment");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment