Commit 498b6514 authored by Julia Lawall's avatar Julia Lawall Committed by Michael Ellerman

powerpc/pseries: delete unneeded test before of_node_put

Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Acked-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 756d3679
...@@ -574,8 +574,7 @@ static void pci_dma_bus_setup_pSeries(struct pci_bus *bus) ...@@ -574,8 +574,7 @@ static void pci_dma_bus_setup_pSeries(struct pci_bus *bus)
while (isa_dn && isa_dn != dn) while (isa_dn && isa_dn != dn)
isa_dn = isa_dn->parent; isa_dn = isa_dn->parent;
if (isa_dn_orig) of_node_put(isa_dn_orig);
of_node_put(isa_dn_orig);
/* Count number of direct PCI children of the PHB. */ /* Count number of direct PCI children of the PHB. */
for (children = 0, tmp = dn->child; tmp; tmp = tmp->sibling) for (children = 0, tmp = dn->child; tmp; tmp = tmp->sibling)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment