Commit 49c57d25 authored by Arnaud Lacombe's avatar Arnaud Lacombe Committed by Michal Marek

scripts/Makefile.build: do not reference EXTRA_CFLAGS as CFLAGS replacement

Usage of these flags has been deprecated for nearly 4 years by:

    commit f77bf014
    Author: Sam Ravnborg <sam@neptun.(none)>
    Date:   Mon Oct 15 22:25:06 2007 +0200

        kbuild: introduce ccflags-y, asflags-y and ldflags-y

Moreover, these flags (at least EXTRA_CFLAGS) have been documented for
command line use. By default, gmake(1) do not override command line
setting, so this is likely to result in build failure or unexpected
behavior.

Do not advertise for its usage.

Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kbuild@vger.kernel.org
Signed-off-by: default avatarArnaud Lacombe <lacombar@gmail.com>
Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
parent 58238c81
...@@ -46,7 +46,7 @@ include $(kbuild-file) ...@@ -46,7 +46,7 @@ include $(kbuild-file)
# If the save-* variables changed error out # If the save-* variables changed error out
ifeq ($(KBUILD_NOPEDANTIC),) ifeq ($(KBUILD_NOPEDANTIC),)
ifneq ("$(save-cflags)","$(CFLAGS)") ifneq ("$(save-cflags)","$(CFLAGS)")
$(error CFLAGS was changed in "$(kbuild-file)". Fix it to use EXTRA_CFLAGS) $(error CFLAGS was changed in "$(kbuild-file)". Fix it to use ccflags-y)
endif endif
endif endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment