Commit 49f96e46 authored by Yangtao Li's avatar Yangtao Li Committed by Ulf Hansson

mmc: cb710: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarYangtao Li <frank.li@vivo.com>
Acked-by: default avatarMichał Mirosław <mirq-linux@rere.qmqm.pl>
Link: https://lore.kernel.org/r/20230727070051.17778-6-frank.li@vivo.comSigned-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 19334c53
...@@ -745,7 +745,7 @@ static int cb710_mmc_init(struct platform_device *pdev) ...@@ -745,7 +745,7 @@ static int cb710_mmc_init(struct platform_device *pdev)
return err; return err;
} }
static int cb710_mmc_exit(struct platform_device *pdev) static void cb710_mmc_exit(struct platform_device *pdev)
{ {
struct cb710_slot *slot = cb710_pdev_to_slot(pdev); struct cb710_slot *slot = cb710_pdev_to_slot(pdev);
struct mmc_host *mmc = cb710_slot_to_mmc(slot); struct mmc_host *mmc = cb710_slot_to_mmc(slot);
...@@ -766,13 +766,12 @@ static int cb710_mmc_exit(struct platform_device *pdev) ...@@ -766,13 +766,12 @@ static int cb710_mmc_exit(struct platform_device *pdev)
tasklet_kill(&reader->finish_req_tasklet); tasklet_kill(&reader->finish_req_tasklet);
mmc_free_host(mmc); mmc_free_host(mmc);
return 0;
} }
static struct platform_driver cb710_mmc_driver = { static struct platform_driver cb710_mmc_driver = {
.driver.name = "cb710-mmc", .driver.name = "cb710-mmc",
.probe = cb710_mmc_init, .probe = cb710_mmc_init,
.remove = cb710_mmc_exit, .remove_new = cb710_mmc_exit,
#ifdef CONFIG_PM #ifdef CONFIG_PM
.suspend = cb710_mmc_suspend, .suspend = cb710_mmc_suspend,
.resume = cb710_mmc_resume, .resume = cb710_mmc_resume,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment