Commit 4ac7534a authored by Prabhakar Kushwaha's avatar Prabhakar Kushwaha Committed by Jeff Garzik

sata_fsl: Fix wrong Device Error Register usage

When a single device error is detected, the device under the error
is indicated by the error bit set in the DER. There is a one to one
mapping between register bit and devices on Port multiplier(PMP)
i.e. bit 0 represents PMP device 0 and bit 1 represents PMP device
1 etc.

Current implementation treats Device error register value as device
number not set of bits representing multiple device on PMP. It is
changed to consider bit level.

No need to check for each set bit as all command is going to be
aborted.
Signed-off-by: default avatarAshish Kalra <B00888@freescale.com>
Signed-off-by: default avatarPrabhakar Kushwaha <prabhakar@freescale.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent 6b3b9d73
...@@ -1039,12 +1039,15 @@ static void sata_fsl_error_intr(struct ata_port *ap) ...@@ -1039,12 +1039,15 @@ static void sata_fsl_error_intr(struct ata_port *ap)
/* find out the offending link and qc */ /* find out the offending link and qc */
if (ap->nr_pmp_links) { if (ap->nr_pmp_links) {
unsigned int dev_num;
dereg = ioread32(hcr_base + DE); dereg = ioread32(hcr_base + DE);
iowrite32(dereg, hcr_base + DE); iowrite32(dereg, hcr_base + DE);
iowrite32(cereg, hcr_base + CE); iowrite32(cereg, hcr_base + CE);
if (dereg < ap->nr_pmp_links) { dev_num = ffs(dereg) - 1;
link = &ap->pmp_link[dereg]; if (dev_num < ap->nr_pmp_links && dereg != 0) {
link = &ap->pmp_link[dev_num];
ehi = &link->eh_info; ehi = &link->eh_info;
qc = ata_qc_from_tag(ap, link->active_tag); qc = ata_qc_from_tag(ap, link->active_tag);
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment