Commit 4b8b3905 authored by Mohamed Khalfella's avatar Mohamed Khalfella Committed by Steven Rostedt (Google)

tracing/histograms: Return an error if we fail to add histogram to hist_vars list

Commit 6018b585 ("tracing/histograms: Add histograms to hist_vars if
they have referenced variables") added a check to fail histogram creation
if save_hist_vars() failed to add histogram to hist_vars list. But the
commit failed to set ret to failed return code before jumping to
unregister histogram, fix it.

Link: https://lore.kernel.org/linux-trace-kernel/20230714203341.51396-1-mkhalfella@purestorage.com

Cc: stable@vger.kernel.org
Fixes: 6018b585 ("tracing/histograms: Add histograms to hist_vars if they have referenced variables")
Signed-off-by: default avatarMohamed Khalfella <mkhalfella@purestorage.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 8a96c028
...@@ -6668,7 +6668,8 @@ static int event_hist_trigger_parse(struct event_command *cmd_ops, ...@@ -6668,7 +6668,8 @@ static int event_hist_trigger_parse(struct event_command *cmd_ops,
goto out_unreg; goto out_unreg;
if (has_hist_vars(hist_data) || hist_data->n_var_refs) { if (has_hist_vars(hist_data) || hist_data->n_var_refs) {
if (save_hist_vars(hist_data)) ret = save_hist_vars(hist_data);
if (ret)
goto out_unreg; goto out_unreg;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment