Commit 4bad78c5 authored by Rob Jones's avatar Rob Jones Committed by Linus Torvalds

lib/dynamic_debug.c: use seq_open_private() instead of seq_open()

Using seq_open_private() removes boilerplate code from ddebug_proc_open().

The resultant code is shorter and easier to follow.

This patch does not change any functionality.
Signed-off-by: default avatarRob Jones <rob.jones@codethink.co.uk>
Acked-by: default avatarJason Baron <jbaron@akamai.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 8b21d9ca
...@@ -819,22 +819,9 @@ static const struct seq_operations ddebug_proc_seqops = { ...@@ -819,22 +819,9 @@ static const struct seq_operations ddebug_proc_seqops = {
*/ */
static int ddebug_proc_open(struct inode *inode, struct file *file) static int ddebug_proc_open(struct inode *inode, struct file *file)
{ {
struct ddebug_iter *iter;
int err;
vpr_info("called\n"); vpr_info("called\n");
return seq_open_private(file, &ddebug_proc_seqops,
iter = kzalloc(sizeof(*iter), GFP_KERNEL); sizeof(struct ddebug_iter));
if (iter == NULL)
return -ENOMEM;
err = seq_open(file, &ddebug_proc_seqops);
if (err) {
kfree(iter);
return err;
}
((struct seq_file *)file->private_data)->private = iter;
return 0;
} }
static const struct file_operations ddebug_proc_fops = { static const struct file_operations ddebug_proc_fops = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment