Commit 4bb1b116 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller

net: sched: move block offload unbind after all chains are flushed

Currently, the offload unbind is done before the chains are flushed.
That causes driver to unregister block callback before it can get all
the callback calls done during flush, leaving the offloaded tps inside
the HW. So fix the order to prevent this situation and restore the
original behaviour.
Reported-by: default avatarAlexander Duyck <alexander.duyck@gmail.com>
Reported-by: default avatarJakub Kicinski <kubakici@wp.pl>
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9a7b96b3
...@@ -343,11 +343,11 @@ void tcf_block_put_ext(struct tcf_block *block, ...@@ -343,11 +343,11 @@ void tcf_block_put_ext(struct tcf_block *block,
if (!block) if (!block)
return; return;
tcf_block_offload_unbind(block, q, ei);
list_for_each_entry_safe(chain, tmp, &block->chain_list, list) list_for_each_entry_safe(chain, tmp, &block->chain_list, list)
tcf_chain_flush(chain); tcf_chain_flush(chain);
tcf_block_offload_unbind(block, q, ei);
INIT_WORK(&block->work, tcf_block_put_final); INIT_WORK(&block->work, tcf_block_put_final);
/* Wait for existing RCU callbacks to cool down, make sure their works /* Wait for existing RCU callbacks to cool down, make sure their works
* have been queued before this. We can not flush pending works here * have been queued before this. We can not flush pending works here
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment