Commit 4bb41984 authored by Sathyanarayana Nujella's avatar Sathyanarayana Nujella Committed by Mark Brown

ASoC: max98373: check for device node before parsing

Below Oops is caused in a system which uses ACPI instead of device node:

of_get_named_gpiod_flags: can't parse 'maxim,reset-gpio' property of node '(null)[0]'
BUG: kernel NULL pointer dereference, address: 0000000000000010

This patch avoids NULL pointer deferencing by adding a check before parsing
and initializes to make reset-gpio pin as invalid.
Signed-off-by: default avatarSathyanarayana Nujella <sathyanarayana.nujella@intel.com>
Signed-off-by: default avatarJairaj Arava <jairaj.arava@intel.com>
Link: https://lore.kernel.org/r/1569702150-11976-1-git-send-email-sathyanarayana.nujella@intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 752c938a
...@@ -901,16 +901,20 @@ static void max98373_slot_config(struct i2c_client *i2c, ...@@ -901,16 +901,20 @@ static void max98373_slot_config(struct i2c_client *i2c,
max98373->i_slot = value & 0xF; max98373->i_slot = value & 0xF;
else else
max98373->i_slot = 1; max98373->i_slot = 1;
if (dev->of_node) {
max98373->reset_gpio = of_get_named_gpio(dev->of_node, max98373->reset_gpio = of_get_named_gpio(dev->of_node,
"maxim,reset-gpio", 0); "maxim,reset-gpio", 0);
if (!gpio_is_valid(max98373->reset_gpio)) { if (!gpio_is_valid(max98373->reset_gpio)) {
dev_err(dev, "Looking up %s property in node %s failed %d\n", dev_err(dev, "Looking up %s property in node %s failed %d\n",
"maxim,reset-gpio", dev->of_node->full_name, "maxim,reset-gpio", dev->of_node->full_name,
max98373->reset_gpio); max98373->reset_gpio);
} else {
dev_dbg(dev, "maxim,reset-gpio=%d",
max98373->reset_gpio);
}
} else { } else {
dev_dbg(dev, "maxim,reset-gpio=%d", /* this makes reset_gpio as invalid */
max98373->reset_gpio); max98373->reset_gpio = -1;
} }
if (!device_property_read_u32(dev, "maxim,spkfb-slot-no", &value)) if (!device_property_read_u32(dev, "maxim,spkfb-slot-no", &value))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment