Commit 4bc33a2c authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

Revert "fbdev: pxa3xx-gcu: remove redundant implementation of open()"

This reverts commit 2bfeeca1.

Not needed after the next patch is applied.

Cc: Martin Kepplinger <martink@posteo.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1b6f4753
...@@ -373,6 +373,15 @@ static inline struct pxa3xx_gcu_priv *to_pxa3xx_gcu_priv(struct file *file) ...@@ -373,6 +373,15 @@ static inline struct pxa3xx_gcu_priv *to_pxa3xx_gcu_priv(struct file *file)
return container_of(dev, struct pxa3xx_gcu_priv, misc_dev); return container_of(dev, struct pxa3xx_gcu_priv, misc_dev);
} }
/*
* provide an empty .open callback, so the core sets file->private_data
* for us.
*/
static int pxa3xx_gcu_open(struct inode *inode, struct file *file)
{
return 0;
}
static ssize_t static ssize_t
pxa3xx_gcu_write(struct file *file, const char *buff, pxa3xx_gcu_write(struct file *file, const char *buff,
size_t count, loff_t *offp) size_t count, loff_t *offp)
...@@ -571,6 +580,7 @@ pxa3xx_gcu_free_buffers(struct device *dev, ...@@ -571,6 +580,7 @@ pxa3xx_gcu_free_buffers(struct device *dev,
static const struct file_operations pxa3xx_gcu_miscdev_fops = { static const struct file_operations pxa3xx_gcu_miscdev_fops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.open = pxa3xx_gcu_open,
.write = pxa3xx_gcu_write, .write = pxa3xx_gcu_write,
.unlocked_ioctl = pxa3xx_gcu_ioctl, .unlocked_ioctl = pxa3xx_gcu_ioctl,
.mmap = pxa3xx_gcu_mmap, .mmap = pxa3xx_gcu_mmap,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment