Commit 4c540a35 authored by Bjorn Helgaas's avatar Bjorn Helgaas

PCI: rcar: Simplify host bridge window iteration

The switch is the only statement in the resource_list_for_each_entry()
loop, so remove unnecessary cases and "continue" statements in the switch.
Inline rcar_pcie_release_of_pci_ranges(), which is only called once.

No functional change intended.
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 6fd7f550
...@@ -938,11 +938,6 @@ static const struct of_device_id rcar_pcie_of_match[] = { ...@@ -938,11 +938,6 @@ static const struct of_device_id rcar_pcie_of_match[] = {
}; };
MODULE_DEVICE_TABLE(of, rcar_pcie_of_match); MODULE_DEVICE_TABLE(of, rcar_pcie_of_match);
static void rcar_pcie_release_of_pci_ranges(struct rcar_pcie *pci)
{
pci_free_resource_list(&pci->resources);
}
static int rcar_pcie_parse_request_of_pci_ranges(struct rcar_pcie *pci) static int rcar_pcie_parse_request_of_pci_ranges(struct rcar_pcie *pci)
{ {
int err; int err;
...@@ -962,28 +957,18 @@ static int rcar_pcie_parse_request_of_pci_ranges(struct rcar_pcie *pci) ...@@ -962,28 +957,18 @@ static int rcar_pcie_parse_request_of_pci_ranges(struct rcar_pcie *pci)
resource_list_for_each_entry(win, &pci->resources) { resource_list_for_each_entry(win, &pci->resources) {
struct resource *res = win->res; struct resource *res = win->res;
switch (resource_type(res)) { if (resource_type(res) == IORESOURCE_IO) {
case IORESOURCE_IO:
err = pci_remap_iospace(res, iobase); err = pci_remap_iospace(res, iobase);
if (err) { if (err)
dev_warn(dev, "error %d: failed to map resource %pR\n", dev_warn(dev, "error %d: failed to map resource %pR\n",
err, res); err, res);
continue;
}
break;
case IORESOURCE_MEM:
break;
case IORESOURCE_BUS:
default:
continue;
} }
} }
return 0; return 0;
out_release_res: out_release_res:
rcar_pcie_release_of_pci_ranges(pci); pci_free_resource_list(&pci->resources);
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment